Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding many missing browser versions #1975

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

jaydiablo
Copy link
Contributor

Fixes #1974

Adding a bunch of missing versions from August of 2018.

I only added UAs to the tests that weren't missing device information, but did confirm that all of them were parsing correctly (initial count was ~950 UAs).

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #1975 into master will decrease coverage by <.01%.
The diff coverage is 43.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1975      +/-   ##
============================================
- Coverage     50.93%   50.93%   -0.01%     
  Complexity      905      905              
============================================
  Files          1696     1696              
  Lines         61164    61176      +12     
  Branches      26817    26827      +10     
============================================
+ Hits          31155    31160       +5     
- Misses        30009    30016       +7
Flag Coverage Δ Complexity Δ
#full 45.85% <43.75%> (-0.01%) 0 <0> (ø)
#lite 2.1% <0%> (-0.01%) 0 <0> (ø)
#standard 26.9% <25%> (ø) 0 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...gents/apps/instagram-app/instagram-app-7-0-on.json 92.07% <ø> (ø) 0 <0> (ø) ⬇️
resources/user-agents/apps/yandex/ya-app-ios.json 42.3% <ø> (ø) 0 <0> (ø) ⬇️
...browsers/seznam-browser/seznam-browser-3-0-on.json 79.16% <ø> (ø) 0 <0> (ø) ⬇️
...browsers/uc-browser/uc-web-desktop-3-0-to-5.8.json 100% <ø> (ø) 0 <0> (?)
...urces/user-agents/browsers/sogou/sogou-mobile.json 84.61% <ø> (ø) 0 <0> (ø) ⬇️
...urces/user-agents/apps/naver/naver-ios-7-0-on.json 83.33% <ø> (ø) 0 <0> (ø) ⬇️
...s/user-agents/apps/snapchat/snapchat-10-33-on.json 92.85% <ø> (ø) 0 <0> (ø) ⬇️
...ser-agents/browsers/icedragon/icedragon-16-on.json 77.77% <ø> (ø) 0 <0> (ø) ⬇️
...owsers/samsung/samsung-android-browser-6-2-on.json 68.3% <ø> (ø) 0 <0> (ø) ⬇️
...ser-agents/browsers/iceweasel/iceweasel-30-40.json 33.33% <ø> (ø) 0 <0> (ø) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606884a...307ad37. Read the comment docs.

@mimmi20 mimmi20 self-assigned this Oct 2, 2018
@mimmi20 mimmi20 added this to the 6.0.31 milestone Oct 2, 2018
@mimmi20 mimmi20 merged commit 63d64c8 into browscap:master Oct 2, 2018
@jaydiablo jaydiablo deleted the issue-1974 branch December 5, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants