Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Edge on Windows 7, 8 and 8.1 #2393

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Conversation

jaydiablo
Copy link
Contributor

Fixes #2390.

Microsoft pushed an update to Windows 7 and 8 this summer that enabled the Chromium Edge browser on those versions of windows: https://betanews.com/2020/06/20/microsoft-edge-windows-7-windows-8/

I pulled some additional UAs from our logs to add test coverage. Also noticed that Headless Edge is available as well, so added that browser with tests: https://headlesstesting.com/blog/edge-headless-testing

Fixes browscap#2390.

Microsoft pushed an update to Windows 7 and 8 this summer that enabled the Chromium Edge browser on those versions of windows: https://betanews.com/2020/06/20/microsoft-edge-windows-7-windows-8/

I pulled some additional UAs from our logs to add test coverage.  Also noticed that Headless Edge is available as well, so added that browser with tests: https://headlesstesting.com/blog/edge-headless-testing
@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #2393 (c1a8176) into 6.0.x (c46be08) will decrease coverage by 0.00%.
The diff coverage is 36.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##              6.0.x    #2393      +/-   ##
============================================
- Coverage     51.78%   51.78%   -0.01%     
  Complexity      899      899              
============================================
  Files          1801     1803       +2     
  Lines         65605    65625      +20     
  Branches      29497    29511      +14     
============================================
+ Hits          33974    33981       +7     
- Misses        31631    31644      +13     
Flag Coverage Δ Complexity Δ
full 46.63% <36.36%> (-0.01%) 0.00 <0.00> (ø)
lite 2.14% <36.36%> (+0.01%) 0.00 <0.00> (ø)
standard 26.86% <36.36%> (+<0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ser-agents/browsers/edge-browser/edge-generic.json 7.14% <0.00%> (-0.41%) 0.00 <0.00> (ø)
...s/browsers/edge-browser/headless-edge-generic.json 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...nts/browsers/edge-browser/headless-edge-76-on.json 57.14% <57.14%> (ø) 0.00 <0.00> (?)
.../user-agents/browsers/edge-browser/edge-76-on.json 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46be08...c1a8176. Read the comment docs.

@mimmi20 mimmi20 self-assigned this Dec 5, 2020
@mimmi20 mimmi20 added this to the 6.0.42 milestone Dec 5, 2020
@mimmi20 mimmi20 merged commit 21db3cd into browscap:6.0.x Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge browser as chrome
2 participants