Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some missing macOS versions to Opera #2394

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

jaydiablo
Copy link
Contributor

Fixes #2379. This fixes situations where Opera was being detected as Chrome on some versions of macOS. Added additional useragents found in our logs to improve test coverage.

There was one test in the suite (1953-BGU) that was actually an Opera UA being detected as Chrome, I removed it from the suite.

Fixes browscap#2379. This fixes situations where Opera was being detected as Chrome on some versions of macOS. Added additional useragents found in our logs to improve test coverage.

There was one test in the suite (1953-BGU) that was actually an Opera UA being detected as Chrome, I removed it from the suite.
@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #2394 (e4bcfcc) into 6.0.x (c46be08) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##              6.0.x    #2394      +/-   ##
============================================
- Coverage     51.78%   51.75%   -0.03%     
  Complexity      899      899              
============================================
  Files          1801     1801              
  Lines         65605    65671      +66     
  Branches      29497    29541      +44     
============================================
+ Hits          33974    33991      +17     
- Misses        31631    31680      +49     
Flag Coverage Δ Complexity Δ
full 46.60% <66.66%> (-0.04%) 0.00 <0.00> (ø)
lite 2.12% <0.00%> (-0.01%) 0.00 <0.00> (ø)
standard 26.85% <66.66%> (-0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...rces/user-agents/browsers/opera/opera-generic.json 34.87% <0.00%> (ø) 0.00 <0.00> (ø)
...ces/user-agents/browsers/opera/opera-37-to-41.json 68.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ources/user-agents/browsers/opera/opera-42-on.json 68.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ources/user-agents/browsers/silk/silk-generic.json 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ts/browsers/miui-browser/miui-browser-generic.json 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...wsers/coc-coc-browser/coc-coc-browser-generic.json 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...r-agents/browsers/chrome/chrome-android-72-on.json 7.76% <0.00%> (+0.10%) 0.00% <0.00%> (ø%)
...ces/user-agents/browsers/uc-browser/uc-web-12.json 88.28% <0.00%> (+0.10%) 0.00% <0.00%> (ø%)
...coc-coc-browser/coc-coc-browser-android-48-on.json 98.11% <0.00%> (+0.11%) 0.00% <0.00%> (ø%)
...ser-agents/browsers/uc-browser/uc-web-generic.json 8.84% <0.00%> (+0.73%) 0.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46be08...e4bcfcc. Read the comment docs.

@mimmi20 mimmi20 merged commit b95dc4f into browscap:6.0.x Dec 5, 2020
@asgrim asgrim added this to the 6.0.42 milestone Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opera 72 on Mac recognized as Chrome 86
3 participants