Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing versions, adding DuckDuckGo browser #2397

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

jaydiablo
Copy link
Contributor

Fixes #2396. This is mostly a version update for various browsers that had no version from our Nov logs. I added Android and iOS versions where necessary as well.

Also noticed a number of DuckDuckGo UAs that appear to go with a DuckDuckGo browser available for Mac, iOS and Android, so added a version-less browser and patterns for those to be detected now.

Apparently Chrome 83 dropped support for Android 4.4, so I split the Chrome and Android Webview files at 82/83 and removed Android 4.4 from the 83+ files.

Fixes browscap#2396.  This is mostly a version update for various browsers that had no version from our Nov logs. I added Android and iOS versions where necessary as well.

Also noticed a number of DuckDuckGo UAs that appear to go with a DuckDuckGo browser available for Mac, iOS and Android, so added a version-less browser and patterns for those to be detected now.

Apparently Chrome 83 dropped support for Android 4.4, so I split the Chrome and Android Webview files at 82/83 and removed Android 4.4 from the 83+ files.
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #2397 (b296c37) into 6.0.x (8e8d1de) will decrease coverage by 0.82%.
The diff coverage is 10.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##              6.0.x    #2397      +/-   ##
============================================
- Coverage     51.77%   50.95%   -0.83%     
  Complexity      899      899              
============================================
  Files          1804     1808       +4     
  Lines         65641    66986    +1345     
  Branches      29524    30484     +960     
============================================
+ Hits          33986    34132     +146     
- Misses        31655    32854    +1199     
Flag Coverage Δ Complexity Δ
full 45.85% <9.66%> (-0.78%) 0.00 <0.00> (ø)
lite 2.12% <0.71%> (-0.02%) 0.00 <0.00> (ø)
standard 26.43% <5.60%> (-0.44%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...rowsers/android-webview/android-webview-83-on.json 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...wsers/android-webview/android-webview-generic.json 36.95% <0.00%> (-2.58%) 0.00 <0.00> (ø)
...r-agents/browsers/chrome/chrome-android-83-on.json 7.73% <0.00%> (ø) 0.00 <0.00> (?)
...agents/browsers/chrome/chrome-android-generic.json 76.19% <0.00%> (-2.50%) 0.00 <0.00> (ø)
...ser-agents/browsers/chrome/chrome-ios-generic.json 60.00% <0.00%> (-3.16%) 0.00 <0.00> (ø)
...ser-agents/browsers/edge-browser/edge-android.json 74.57% <0.00%> (-2.62%) 0.00 <0.00> (ø)
...ser-agents/browsers/edge-browser/edge-generic.json 6.66% <0.00%> (-0.48%) 0.00 <0.00> (ø)
...rs/firefox-on-android/firefox-android-generic.json 10.41% <0.00%> (-1.49%) 0.00 <0.00> (ø)
...s/browsers/firefox-on-ios/firefox-ios-generic.json 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../browsers/mobile-safari/mobile-safari-generic.json 40.49% <0.00%> (-1.39%) 0.00 <0.00> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8d1de...b296c37. Read the comment docs.

@asgrim asgrim merged commit 965c250 into browscap:6.0.x Dec 7, 2020
@asgrim
Copy link
Member

asgrim commented Dec 7, 2020

Thanks @jaydiablo 👍

@asgrim asgrim self-assigned this Dec 7, 2020
@asgrim asgrim added this to the 6.0.42 milestone Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Another version update from Nov 2020
2 participants