issue-2491 #2492
Merged
issue-2491 #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented issue-2491.
Added some more variants.
Closed
Closed
mimmi20
requested changes
May 26, 2021
| @@ -2328,6 +2328,54 @@ | |||
| { | |||
| "match": "NinjBot/*", | |||
| "browser": "ninj-bot" | |||
| }, | |||
| { | |||
| "match": "Yewno-Open", | |||
There was a problem hiding this comment.
Please add a * at the end of all new rules, even if they are static. Otherwise they may are missing in the generated file
| "browser": "isp_testing_suite" | ||
| }, | ||
| { | ||
| "match": "Asana/1.4.0 WebsiteMetadataRetriever", |
There was a problem hiding this comment.
Please replace the version numer with a *
| "browser": "magnetbot" | ||
| }, | ||
| { | ||
| "match": "Caliperbot/1.0 (+http://www.conductor.com/caliperbot)", |
There was a problem hiding this comment.
Please replace the version numer with a *
| "browser": "doximity-pipeline" | ||
| }, | ||
| { | ||
| "match": "MVision/1.0", |
There was a problem hiding this comment.
Please replace the version numer with a *
| "browser": "charlotte" | ||
| }, | ||
| { | ||
| "match": "CEPCrawler (newswatch-admin@basf.com)", |
There was a problem hiding this comment.
Please replace the content after ( with a *
| "browser": "yewno-open" | ||
| }, | ||
| { | ||
| "match": "M", |
There was a problem hiding this comment.
Please do not add single letter UAs
| "browser": "m-vision" | ||
| }, | ||
| { | ||
| "match": "Charlotte: The Financial Institution Crawler - 2000ms of politeness, robot friendly crawling", |
There was a problem hiding this comment.
Please replace the content after Crawler with a *
Implemented review feedback.
mimmi20
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented issue-2491.