Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mobile Safari up to 15.4 #2567

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Conversation

willyaranda
Copy link
Contributor

No description provided.

Copy link
Member

@mimmi20 mimmi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one unit test or more

Copy link
Member

@mimmi20 mimmi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these new versions exist also for the non-mobile Safari? If yes, please add the versions for the non-mobile Safari too.

@willyaranda
Copy link
Contributor Author

@mimmi20 sorry, I was working on rebuilding my setup as there was a bump to PHP8 :)

  • I have added the tests
  • The Desktop Safaris had this versions added, but not on mobile

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #2567 (d2e915b) into 6.0.x (8c95f1b) will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##              6.0.x    #2567   +/-   ##
=========================================
  Coverage     51.02%   51.02%           
  Complexity      875      875           
=========================================
  Files          1816     1816           
  Lines         67488    67488           
  Branches      30611    30611           
=========================================
  Hits          34439    34439           
  Misses        33049    33049           
Flag Coverage Δ
full 45.87% <66.66%> (+<0.01%) ⬆️
lite 2.11% <0.00%> (ø)
standard 26.51% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/browsers/mobile-safari/mobile-safari-15-x.json 59.25% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c95f1b...d2e915b. Read the comment docs.

tests/issues/issue-2567.php Outdated Show resolved Hide resolved
@mimmi20 mimmi20 requested a review from asgrim February 1, 2022 18:39
@willyaranda
Copy link
Contributor Author

willyaranda commented Feb 1, 2022 via email

@asgrim asgrim added this to the 6.0.52 milestone Feb 2, 2022
@asgrim asgrim merged commit b2f1501 into browscap:6.0.x Feb 2, 2022
@asgrim
Copy link
Member

asgrim commented Feb 3, 2022

Thanks @willyaranda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants