Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md fixes / suggestions #2760

Merged
merged 3 commits into from
Jan 8, 2023
Merged

README.md fixes / suggestions #2760

merged 3 commits into from
Jan 8, 2023

Conversation

chappy84
Copy link
Contributor

@chappy84 chappy84 commented Jan 8, 2023

Various fixes / suggestions for the custom file generator section of the README

@asgrim asgrim self-assigned this Jan 8, 2023
@asgrim asgrim added this to the 6.1.3 milestone Jan 8, 2023
@asgrim asgrim enabled auto-merge January 8, 2023 20:10
Copy link
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chappy84 !

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Base: 50.96% // Head: 29.36% // Decreases project coverage by -21.60% ⚠️

Coverage data is based on head (948d576) compared to base (78fbad5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##              6.1.x    #2760       +/-   ##
=============================================
- Coverage     50.96%   29.36%   -21.61%     
  Complexity      875      875               
=============================================
  Files          1820     1820               
  Lines         68000    68000               
  Branches      30718    30718               
=============================================
- Hits          34659    19965    -14694     
- Misses        33341    48035    +14694     
Flag Coverage Δ
full ?
lite 2.10% <ø> (ø)
phpunit 74.07% <ø> (ø)
standard 26.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
resources/user-agents/browsers/ie/ie-mac.json 0.00% <0.00%> (-100.00%) ⬇️
resources/user-agents/apps/apple/cyberdog.json 0.00% <0.00%> (-100.00%) ⬇️
resources/user-agents/browsers/misc/sharp.json 0.00% <0.00%> (-100.00%) ⬇️
resources/user-agents/browsers/misc/webpirate.json 0.00% <0.00%> (-100.00%) ⬇️
...ources/user-agents/browsers/wap-browser/iball.json 0.00% <0.00%> (-100.00%) ⬇️
...ources/user-agents/browsers/wap-browser/mstar.json 0.00% <0.00%> (-100.00%) ⬇️
...rces/user-agents/browsers/misc/pirate-browser.json 0.00% <0.00%> (-100.00%) ⬇️
...rces/user-agents/browsers/omniweb/omniweb-4-x.json 0.00% <0.00%> (-100.00%) ⬇️
.../user-agents/browsers/ie-mobile/iemobile-3-02.json 0.00% <0.00%> (-100.00%) ⬇️
...ser-agents/crawlers/gomezagent/gomezagent-2-0.json 0.00% <0.00%> (-100.00%) ⬇️
... and 569 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@asgrim asgrim merged commit 76b7bcf into browscap:6.1.x Jan 8, 2023
@chappy84 chappy84 deleted the readme_fix branch January 8, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants