Allow FilterCollection to be used anywhere that FilterInterface can be used #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
approved these changes
Jan 8, 2023
Codecov ReportBase: 50.96% // Head: 50.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 6.1.x #2761 +/- ##
=========================================
Coverage 50.96% 50.97%
- Complexity 875 876 +1
=========================================
Files 1820 1820
Lines 68000 68002 +2
Branches 30718 30718
=========================================
+ Hits 34659 34661 +2
Misses 33341 33341
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin really.
I wanted to combine the
CustomFilterwith theStandardFilter, so I could reduce the number of fields, but retain the smaller size of the standard file. TheFilterCollectioncouldn't be passed toWriterCollection::setFilteras it didn't implementFilterInterface, but it seemed to make sense allow a combination of filters to be passed to this, andFilterCollectionseemingly being intended for this purpose, hence these updates.