Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recent and future chrome, edge and firefox versions, up until 125 #2880

Conversation

paulrutter
Copy link
Contributor

@paulrutter paulrutter commented Jul 25, 2023

Fixes #2827

  • Add recent and future chrome, edge and firefox versions, up until 125

- Add recent and future chrome, edge and firefox versions, up until 125
@paulrutter
Copy link
Contributor Author

The unit tests fail, would need to check those later.

Copy link
Member

@mimmi20 mimmi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new versions also for the Desktop Chrome, the Headless Chrome and the Android Webview

@mimmi20 mimmi20 requested a review from asgrim July 26, 2023 04:52
- Add Android webview, firefox on iOS and headless chrome
@paulrutter
Copy link
Contributor Author

I added the requested changes, awaiting the unit tests.
Maybe i'll add a few other useragents to the unit tests, please wait before merging.

- Add two useragents, Chrome 115 on MacOSX and Chrome 115 on iOS
@mimmi20 mimmi20 self-requested a review July 26, 2023 08:41
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.89% ⚠️

Comparison is base (971db81) 51.34% compared to head (7622d27) 49.46%.

Additional details and impacted files
@@             Coverage Diff              @@
##              6.1.x    #2880      +/-   ##
============================================
- Coverage     51.34%   49.46%   -1.89%     
============================================
  Files          1822     1756      -66     
  Lines         68338    64808    -3530     
  Branches      30912    30912              
============================================
- Hits          35090    32055    -3035     
+ Misses        33248    32753     -495     
Flag Coverage Δ
full 45.79% <ø> (+<0.01%) ⬆️
lite ?
phpunit ?
standard 26.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rowsers/android-webview/android-webview-83-on.json 7.11% <ø> (-0.42%) ⬇️
...rces/user-agents/browsers/chrome/chrome-66-on.json 46.93% <ø> (ø)
...r-agents/browsers/chrome/chrome-android-83-on.json 12.05% <ø> (-0.14%) ⬇️
.../user-agents/browsers/chrome/chrome-ios-73-on.json 80.00% <ø> (-3.34%) ⬇️
...-agents/browsers/chrome/headless-chrome-60-on.json 65.00% <ø> (-5.00%) ⬇️
.../user-agents/browsers/chromium/chromium-55-on.json 39.02% <ø> (ø)
.../user-agents/browsers/edge-browser/edge-76-on.json 84.61% <ø> (ø)
...ser-agents/browsers/edge-browser/edge-android.json 69.86% <ø> (-1.37%) ⬇️
...es/user-agents/browsers/edge-browser/edge-ios.json 77.77% <ø> (-5.56%) ⬇️
...sers/firefox-on-android/firefox-android-48-on.json 88.88% <ø> (ø)
... and 4 more

... and 113 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulrutter
Copy link
Contributor Author

I added a few more user agents, i'm good with merging and releasing this one.
@asgrim @mimmi20

@asgrim
Copy link
Member

asgrim commented Jul 26, 2023

Thank you @paulrutter !

@asgrim asgrim self-assigned this Jul 26, 2023
@asgrim asgrim added this to the 6.1.5 milestone Jul 26, 2023
@asgrim asgrim merged commit f40aead into browscap:6.1.x Jul 26, 2023
25 of 26 checks passed
@paulrutter paulrutter deleted the feature/2827-add-recent-and-future-chrome-based-browser-versions branch July 26, 2023 08:48
@paulrutter
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome 113 not detected with php_browscap Version=6001003
3 participants