Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer miller-rabin@1.1.2 wants bn.js@^0.16.0 #5

Closed
barneycarroll opened this issue Jan 2, 2015 · 31 comments
Closed

Peer miller-rabin@1.1.2 wants bn.js@^0.16.0 #5

barneycarroll opened this issue Jan 2, 2015 · 31 comments

Comments

@barneycarroll
Copy link

No description provided.

@mchlbrnd
Copy link

mchlbrnd commented Jan 2, 2015

guybedford@d865eaa

barneycarroll added a commit to barneycarroll/diffie-hellman that referenced this issue Jan 2, 2015
@AlexGalays
Copy link

Just when I deleted node_modules, npm install again :)

@j0hnsmith
Copy link

I see the same, please push fix to npm.

@pluma
Copy link

pluma commented Jan 2, 2015

+1

browserify has a deep dependency on this package, so this bug is currently affecting anyone trying to install browserify :/

@rhalff
Copy link

rhalff commented Jan 2, 2015

+1 never heard of this package yet my code is failing :-)

@mstefaniuk
Copy link

+1

1 similar comment
@p3k
Copy link

p3k commented Jan 2, 2015

+1

@rhalff
Copy link

rhalff commented Jan 2, 2015

I'll star the package just to pay gratitude to it's relevance.. ;-)

TiddoLangerak referenced this issue in indutny/miller-rabin Jan 2, 2015
@TiddoLangerak
Copy link

For anyone having this problem, you can temporary work around it by installing miller-rabin@1.1.1 as a ~~peer-~~dependency in your own project (npm install miller-rabin@1.1.1 --save --save-exact). This ensures bn.js@0.15 is used instead.

EDIT: Apparently it doesn't work when added as a peer dependency, my bad. Should be a normal or dev dependency.

@hugofqueiros
Copy link

+1

@jnoleau
Copy link

jnoleau commented Jan 2, 2015

+1

@calvinmetcalf
Copy link
Contributor

Will fix all these this evening or first thing tommorow

On Fri, Jan 2, 2015, 12:47 PM Julien Noleau notifications@github.com
wrote:

+1


Reply to this email directly or view it on GitHub
#5 (comment)
.

@sergeyzenchenko
Copy link

+1

@paulreeve
Copy link

+1

2 similar comments
@marcio
Copy link

marcio commented Jan 2, 2015

+1

@andreitr
Copy link

andreitr commented Jan 2, 2015

+1

@DavidSouther
Copy link

@calvinmetcalf Your package is so deep in the dependency list, this issue is causing hell for basically anyone trying to do anything with Browserify and several others. Please either take time to fix (should be as easy as merging one of the three open PRs) and publishing, or granthing authority on this repo and npmjs for another to do so.

@mchlbrnd
Copy link

mchlbrnd commented Jan 2, 2015

@DavidSouther +1

@cwonrails
Copy link

+1

@gautamarora
Copy link

+1 thanks for the temporary work around @TiddoLangerak

@thetutlage
Copy link

Got up working great indutny/miller-rabin@bb85f55

@DavidSouther
Copy link

Good news everyone! This issue has been fixed downstream! It can now be closed! Thanks for jumping on it, @indutny!

@cwonrails
Copy link

Awesome, thanks @indutny!

@barneycarroll
Copy link
Author

Nice, thanks @TiddoLangerak for pointing this out.

@AlexGalays
Copy link

image

@Kagami
Copy link

Kagami commented Jan 2, 2015

2823171-we_did_it

@thetutlage
Copy link

It is causing issue again on installing packages globally

Peer miller-rabin@1.1.2 wants bn.js@^0.16.0

@indutny
Copy link

indutny commented Jan 3, 2015

@thetutlage it is 1.1.4 now, please clear your cache.

@calvinmetcalf
Copy link
Contributor

sorry for this, was literally at the airport about to get on plain when this was raised. This plain, mind you, after take off had a flap problem and had to land but first had to spend several hours burning off fuel by flying in circles before relanding at the airport we took off from. Thank you to all that fixed this while I was circling the Atlantic specifically @guybedford and @indutny

@indutny
Copy link

indutny commented Jan 3, 2015

Glad that everything is fine.

@DavidSouther
Copy link

Hah, talk about perfect worst timing! We always used to joke about key devs getting hit by a bus, but I'll have to add this scenario to a disaster prep plan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests