Skip to content

Commit

Permalink
package: update bn.js
Browse files Browse the repository at this point in the history
  • Loading branch information
@guybedford @indutny
guybedford authored and indutny committed Jan 2, 2015
1 parent 59a943d commit bb85f55
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Expand Up @@ -22,11 +22,11 @@
},
"homepage": "https://github.com/indutny/miller-rabin",
"devDependencies": {
"bn.js": "^0.15.0",
"bn.js": "^0.16.0",
"mocha": "^2.0.1"
},
"peerDependencies": {
"bn.js": "^0.15.0"
"bn.js": "^0.16.0"
},
"dependencies": {
"brorand": "^1.0.1"
Expand Down

21 comments on commit bb85f55

@TiddoLangerak
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, e.g. browserify can no longer be installed because a conflict of peer dependencies with diffie-hellman. Could you consider to release a new 1.1.x version with the old dependency, and delay the hard upgrade of the bn.js dependency to a major version, such that it complies with semver (and thus browserify is usuable again)?

@cliftonc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@unindented
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BorePlusPlus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mseddon
Copy link

@mseddon mseddon commented on bb85f55 Jan 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jhollingworth
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kharhys
Copy link

@kharhys kharhys commented on bb85f55 Jan 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jessy1092
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@detrandix
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gigablox
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonhischier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tom-smalls
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andreitr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattdew
Copy link

@mattdew mattdew commented on bb85f55 Jan 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CodisRedding
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lambert-velir
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tinchoz49
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mathieumure
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CodisRedding
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workaround: webpro/DOMtastic@7c0396a

@indutny
Copy link
Owner

@indutny indutny commented on bb85f55 Jan 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now, sorry!

@thetutlage
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks working fine

Please sign in to comment.