Skip to content

Commit

Permalink
test: fix on old Node versions
Browse files Browse the repository at this point in the history
  • Loading branch information
zkochan committed Jul 25, 2017
1 parent 86e3310 commit 991944d
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 11 deletions.
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"scripts": {
"prepublish": "safe-publish-latest",
"lint": "eslint .",
"pretests-only": "symlink-dir test/resolver/symlinked/_/symlink_target test/resolver/symlinked/symlink",
"tests-only": "tape test/*.js",
"pretest": "npm run lint",
"test": "npm run --silent tests-only"
Expand All @@ -26,7 +25,6 @@
"eslint": "^3.19.0",
"object-keys": "^1.0.11",
"safe-publish-latest": "^1.1.1",
"symlink-dir": "^1.1.0",
"tap": "0.4.13",
"tape": "^4.6.3"
},
Expand Down
26 changes: 17 additions & 9 deletions test/symlinks.js
Original file line number Diff line number Diff line change
@@ -1,46 +1,54 @@
var path = require('path');
var fs = require('fs');
var test = require('tape');
var resolve = require('../');

var symlinkDir = path.join(__dirname, 'resolver', 'symlinked', 'symlink');
try {
fs.unlinkSync(symlinkDir);
} catch (err) {}
try {
fs.symlinkSync('./_/symlink_target', symlinkDir, 'dir');
} catch (err) {
// if fails then it is probably on Windows and lets try to create a junction
fs.symlinkSync(path.join(__dirname, 'resolver', 'symlinked', '_', 'symlink_target') + '\\', symlinkDir, 'junction');
}

test('symlink', function (t) {
t.plan(1);
var dir = path.join(__dirname, 'resolver', 'symlinked', 'symlink');

resolve('foo', { basedir: dir }, function (err, res, pkg) {
resolve('foo', { basedir: symlinkDir }, function (err, res, pkg) {
if (err) t.fail(err);
t.equal(res, path.join(__dirname, 'resolver', 'symlinked', '_', 'node_modules', 'foo.js'));
});
});

test('sync symlink when preserveSymlinks = true', function (t) {
t.plan(4);
var dir = path.join(__dirname, 'resolver', 'symlinked', 'symlink');

resolve('foo', { basedir: dir, preserveSymlinks: true }, function (err, res, pkg) {
resolve('foo', { basedir: symlinkDir, preserveSymlinks: true }, function (err, res, pkg) {
t.ok(err, 'there is an error');
t.notOk(res, 'no result');

t.equal(err && err.code, 'MODULE_NOT_FOUND', 'error code matches require.resolve');
t.equal(
err && err.message,
'Cannot find module \'foo\' from \'' + dir + '\'',
'Cannot find module \'foo\' from \'' + symlinkDir + '\'',
'can not find nonexistent module'
);
});
});

test('sync symlink', function (t) {
var start = new Date();
var dir = path.join(__dirname, 'resolver', 'symlinked', 'symlink');
t.equal(resolve.sync('foo', { basedir: dir }), path.join(__dirname, 'resolver', 'symlinked', '_', 'node_modules', 'foo.js'));
t.equal(resolve.sync('foo', { basedir: symlinkDir }), path.join(__dirname, 'resolver', 'symlinked', '_', 'node_modules', 'foo.js'));
t.ok(new Date() - start < 50, 'resolve.sync timedout');
t.end();
});

test('sync symlink when preserveSymlinks = true', function (t) {
var dir = path.join(__dirname, 'resolver', 'symlinked', 'symlink');
t.throws(function () {
resolve.sync('foo', { basedir: dir, preserveSymlinks: true });
resolve.sync('foo', { basedir: symlinkDir, preserveSymlinks: true });
}, /Cannot find module 'foo'/);
t.end();
});

0 comments on commit 991944d

Please sign in to comment.