Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve 1.13.0 fails to find bootstrap's package.json #204

Closed
orthur opened this issue Nov 26, 2019 · 2 comments
Closed

Resolve 1.13.0 fails to find bootstrap's package.json #204

orthur opened this issue Nov 26, 2019 · 2 comments

Comments

@orthur
Copy link

orthur commented Nov 26, 2019 •
edited
Loading

We have faced issues with new version of resolve.

ERROR in ./node_modules/bootstrap-loader/lib/bootstrap.loader.js?extractStyles!./node_modules/bootstrap-loader/no-op.js
Module build failed: Error: Cannot find module '/builds/node_modules/bootstrap/package.json/package.json'
    at Function.Module._resolveFilename (module.js:548:15)
    at Function.Module._load (module.js:475:25)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at exports.default (/builds/node_modules/bootstrap-loader/lib/utils/checkBootstrapVersion.js:8:20)
    at Object.module.exports.pitch (/builds/node_modules/bootstrap-loader/lib/bootstrap.loader.js:159:65)
 @ ./node_modules/bootstrap-loader/extractStyles.js 2:0-58
 @ multi whatwg-fetch babel-polyfill ./app.js bootstrap-loader/extractStyles

Note node_modules/bootstrap/package.json/package.json instead of node_modules/bootstrap/package.json
same error as in #157
@ljharb
Copy link
Member

ljharb commented Nov 26, 2019

oops, looks like i repeated the same mistake again. I'll revert and release a v1.13.0 shortly.

ljharb added a commit that referenced this issue Nov 26, 2019
@ljharb
[Fix] sync: packageFilter: revert "breaking" change in 9f06a8f / #…
c479bbb 
…202

Fixes #204.

This was a repeat of an unintentionally breaking bugfix which
caused #157, which was reverted in f5c2a41,
which #202 regressed to cause #204.

This time, I've added lots of comments so I won't accidentally do this again.
@ljharb
Copy link
Member

ljharb commented Nov 26, 2019

v1.13.1 and v1.12.3 are released with this fix. Sorry for the inconvenience!

ljharb added a commit that referenced this issue Nov 26, 2019
@ljharb
v1.13.1
9591fb7 
  - [Fix] `sync`: `packageFilter`: revert "breaking" change in #202 (#204, #202, #157)
@ljharb ljharb closed this as completed in 07612f7 Nov 26, 2019
ljharb added a commit that referenced this issue Nov 26, 2019
@ljharb
[Fix] sync: packageFilter: revert "breaking" change in 9f06a8f / #…
ca0fa41 
…202

Fixes #204.

This was a repeat of an unintentionally breaking bugfix which
caused #157, which was reverted in f5c2a41,
which #202 regressed to cause #204.

This time, I've added lots of comments so I won't accidentally do this again.
ljharb added a commit that referenced this issue Nov 26, 2019
@ljharb
v1.12.3
7967adc 
  - [Fix] `sync`: `packageFilter`: revert "breaking" change in #202 (#204, #202, #157)
  - [Dev Deps] update `eslint`
  - [Tests] fix symlink tests for windows
This was referenced Jan 13, 2020
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this issue Mar 5, 2020
Open
This was referenced Mar 15, 2020
Open
Closed
This was referenced Mar 25, 2020
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @orthur