Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: packageFilter passes expected arguments #202

Merged
merged 1 commit into from
Nov 22, 2019
Merged

fix: packageFilter passes expected arguments #202

merged 1 commit into from
Nov 22, 2019

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Nov 19, 2019 •
edited by ljharb
Loading

No description provided.

@ljharb
Copy link
Member

ljharb commented Nov 20, 2019

@manucorporat can you please provide a regression test?

ljharb
ljharb approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ended up being rolled up into my fix for #201, so I'm going to pull this in as-is.

@ljharb ljharb mentioned this pull request Nov 22, 2019
Closed
@ljharb ljharb merged commit f4081ef into browserify:master Nov 22, 2019
ljharb pushed a commit that referenced this pull request Nov 22, 2019
@manucorporat @ljharb
fix: packageFilter passes expected arguments
8748c19 
(see #202)
ljharb pushed a commit that referenced this pull request Nov 22, 2019
@manucorporat @ljharb
fix: packageFilter passes expected arguments
38b1859 
(see #202)
ljharb pushed a commit that referenced this pull request Nov 22, 2019
@manucorporat @ljharb
fix: packageFilter passes expected arguments
2b57f2a 
(see #202)
ljharb pushed a commit that referenced this pull request Nov 22, 2019
@manucorporat @ljharb
fix: packageFilter passes expected arguments
166239d 
(see #202)
ljharb pushed a commit that referenced this pull request Nov 22, 2019
@manucorporat @ljharb
fix: packageFilter passes expected arguments
9f06a8f 
(see #202)
ljharb added a commit that referenced this pull request Nov 26, 2019
@ljharb
[Fix] sync: packageFilter: revert "breaking" change in 9f06a8f / #…
c479bbb 
…202

Fixes #204.

This was a repeat of an unintentionally breaking bugfix which
caused #157, which was reverted in f5c2a41,
which #202 regressed to cause #204.

This time, I've added lots of comments so I won't accidentally do this again.
ljharb added a commit that referenced this pull request Nov 26, 2019
@ljharb
[Fix] sync: packageFilter: revert "breaking" change in 9f06a8f / #…
07612f7 
…202

Fixes #204.

This was a repeat of an unintentionally breaking bugfix which
caused #157, which was reverted in f5c2a41,
which #202 regressed to cause #204.

This time, I've added lots of comments so I won't accidentally do this again.
ljharb added a commit that referenced this pull request Nov 26, 2019
@ljharb
v1.13.1
9591fb7 
  - [Fix] `sync`: `packageFilter`: revert "breaking" change in #202 (#204, #202, #157)
ljharb added a commit that referenced this pull request Nov 26, 2019
@ljharb
[Fix] sync: packageFilter: revert "breaking" change in 9f06a8f / #…
ca0fa41 
…202

Fixes #204.

This was a repeat of an unintentionally breaking bugfix which
caused #157, which was reverted in f5c2a41,
which #202 regressed to cause #204.

This time, I've added lots of comments so I won't accidentally do this again.
ljharb added a commit that referenced this pull request Nov 26, 2019
@ljharb
v1.12.3
7967adc 
  - [Fix] `sync`: `packageFilter`: revert "breaking" change in #202 (#204, #202, #157)
  - [Dev Deps] update `eslint`
  - [Tests] fix symlink tests for windows
This was referenced Jan 13, 2020
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 5, 2020
Open
This was referenced Mar 15, 2020
Open
Closed
This was referenced Mar 25, 2020
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manucorporat @ljharb