Conversation
Add the possibility to make `resolve` use real paths during resolution. Fixes browserify#130.
zkochan
force-pushed
the
master
branch
2 times, most recently
from
991944d to
0fa967f
Compare
|
@ljharb could you please review this? although Travis is failing on some node versions, it doesn't seem to be caused by these changes. |
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Thanks, this looks great - tests should be fixed on master; after a rebase we should be good to go!
|
|
||
| if (!opts || !opts.preserveSymlinks) { | ||
| try { | ||
| absoluteStart = fs.realpathSync(absoluteStart); |
There was a problem hiding this comment.
it is worth noting that this line means that this file will now not work in a browser; whereas i think it would have prior
| }); | ||
|
|
||
| test('sync symlink', function (t) { | ||
| var start = new Date(); |
There was a problem hiding this comment.
we should be able to use Date.now() here, nbd tho
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
I've just done the rebase for you; but perhaps we shouldn't make this be a breaking change by enabling the behavior by default?
|
Thanks!
I think |
|
Yeah - let's do that (have it default to true for now) and release a semver-minor. I'll plan a breaking change in the future that flips it to |
|
OK cool, I'll push the change in a few minutes |
zkochan
force-pushed
the
master
branch
2 times, most recently
from
771468e to
3cd8620
Compare
|
Changed Added a notice to README about changing the default value of |
For context see: browserify/resolve#131 This fixes browserify for projects that use pnpm. Related issue at pnpm: pnpm/pnpm#795
2 participants
Ref #130