Security Issues #18
Merged
Security Issues #18
Conversation
Thanks for the patch. I've released this as 2.0.0 because there are some package such as static-module that break with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This should address the unsafe code in ExpressionStatement / FunctionExpression blocks:
As well as the issue described at #4. The current fix for this is to not all any member expressions to resolve from a function.
I believe the next step should be to try to refactor out the dynamic Function call completely.