Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--delay and --poll options #139

Closed
wants to merge 2 commits into from
Closed

Conversation

mattdesl
Copy link
Contributor

Adding some new features: --poll (enable chokidar polling) and --delay (for faster incremental bundling on some systems).

On my system this speeds up reload time by 600ms which is pretty huge.

  • fixing bin/args.js to use the args param and pass options to watchify
  • removing unused require in bin/cmd.js
  • making the existing delay option allow zero
  • adding a --poll option for chokidar

Would be happy to add tests/docs etc.

@ccapndave
Copy link

+1 for this PR. I have a client who needs to use gulp and watchify to build a project in an Ubuntu Vagrant box on Windows (because it too much of a hassle doing it natively). chokidar only picks up changes in VirtualBox synced folders with polling, so allowing watchify to specify chokidar usePolling would make this work nicely for us.

@jonbretman
Copy link

👍 would love to see this get merged. Have the same problem with using watchify inside Vagrant.

@zertosh
Copy link
Member

zertosh commented Mar 23, 2015

@mattdesl How about something like #139 instead?

@zertosh
Copy link
Member

zertosh commented Mar 23, 2015

Derp... sorry I meant #126

@mattdesl
Copy link
Contributor Author

Yeah that could be good too. My main motivation was exposing this for CLI -- whereas usePolling or subarg syntax is a bit more cumbersome.

@zertosh
Copy link
Member

zertosh commented Mar 23, 2015

hmm --chokidar [ --usePolling ] is kind of a mouthful. I think the only two* options people seem to want to pass to chokidar are ignored and usePolling (and by association interval). I'm going to open a new issue to consolidate the "pass options to chokidar" discussion.

@zertosh
Copy link
Member

zertosh commented Mar 23, 2015

Closing and moving discussion to #162.

@zertosh zertosh closed this Mar 23, 2015
@mattdesl
Copy link
Contributor Author

Note the --delay option wasn't part of chokidar; it's the hard-coded 600ms wait which is unnecessary for many machines.

@zertosh
Copy link
Member

zertosh commented Mar 23, 2015

@mattdesl Ah true - sorry. How about a PR just for that?

@zertosh
Copy link
Member

zertosh commented Mar 23, 2015

--delay was added in #163

@zertosh
Copy link
Member

zertosh commented Mar 30, 2015

--poll (among other things) was added in #170 and published as 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants