-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --ignore-watch option, pass --delay option from cmd.js, documentation. #65
Conversation
+1 |
@STRML: I really like this. It seems that you were not only not adding watchers but you weren't caching ignored files. I think the value here is not attaching watchers but still caching. I know this is almost a year later. If you don't have a use for this anymore, please let me know and I'll make the changes. |
I think chokidar can handle this. Starting with chokidar.watch('/src/node_modules/react/lib/react.js', {ignored: '**/node_modules/**'}); still returns a chokidar instance, but it won't actually attach any fs watchers. chokidar instances are cheap, it's the fs watching that's expensive. @es128 can you confirm that this is chokidar's behavior across fs.watch / fs.watchFile / fsevents? |
Yep, same sort of thing happening on the other side |
Thanks @es128! Is a stable chokidar@1.0.0 in the near future? Or is it pretty safe/stable as it is right now? |
It is very stable as is, and I'm also on the verge of releasing 1.0.0. There's a handful of open issues still, but no showstoppers. |
FYI rc5 is on the cusp of being published, and as long as nothing explodes, 1.0.0 in about a week |
--ignore-watch=glob
(or{ignoreWatch: String|RegExp}
) allows the user to cut down on used CPU / open file descriptors by ignoring watching of certain files. Useful for ignoring files you know should not change, likenode_modules
.Fixes #11, and does not clobber the
ignore
option like #31.