Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version file generation is done in the src tree #161

Closed
XapaJIaMnu opened this issue May 18, 2021 · 1 comment · Fixed by #193 or #194
Closed

Version file generation is done in the src tree #161

XapaJIaMnu opened this issue May 18, 2021 · 1 comment · Fixed by #193 or #194
Assignees
@abhi-agg

Comments

@XapaJIaMnu
Copy link
Collaborator

XapaJIaMnu commented May 18, 2021 •
edited
Loading

@abhi-agg it is bad practise to have cmake generate files in the source directory. If a file is generated after configure, it should be in ${CMAKE_BINARY_DIR}, not in src/translator/project_version.h.

At the very least, you can add a .gitignore entry for it so that this file is not accidentally picked up by someone working on the project.

I have not fixed this myself, as other projects also read this file, and I am not sure where exactly things need to be updated.
@kpu
Copy link
Member

kpu commented May 18, 2021

Agreed, generated files go in the binary directory.

@kpu kpu mentioned this issue May 31, 2021
Closed
@jerinphilip jerinphilip mentioned this issue Jun 8, 2021
Merged
@abhi-agg abhi-agg mentioned this issue Jun 9, 2021
Merged
XapaJIaMnu pushed a commit that referenced this issue Jun 9, 2021
@abhi-agg
Generating cmake configured project version (.js) file in build folder (
16eb47f 
#194)

- Earlier this file was being generated in folder containing
   actual sources

 - Fixes #161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhi-agg abhi-agg

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kpu @XapaJIaMnu @abhi-agg