Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git-ignore generated project version files #164

Closed
wants to merge 1 commit into from
Closed

Git-ignore generated project version files #164

wants to merge 1 commit into from

Conversation

motin
Copy link
Contributor

@motin motin commented May 19, 2021

Git-ignore generated project version files from #153

@kpu
Copy link
Member

kpu commented May 31, 2021 •
edited
Loading

We shouldn't do this. They should be built properly in the build directory. #161

kpu
kpu requested changes May 31, 2021
View reviewed changes
Copy link
Member

@kpu kpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't generate the version files in the source tree #161

@motin
Copy link
Contributor Author

motin commented Jun 1, 2021

Don't generate the version files in the source tree #161

Agree, that is a much better approach. Closing.

@motin motin closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpu kpu kpu requested changes

@jerinphilip jerinphilip Awaiting requested review from jerinphilip

@andrenatal andrenatal Awaiting requested review from andrenatal

@XapaJIaMnu XapaJIaMnu Awaiting requested review from XapaJIaMnu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@motin @kpu