Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced Versioning mechanism for wasm and native artifacts #153

Merged
merged 5 commits into from
May 17, 2021
Merged

Introduced Versioning mechanism for wasm and native artifacts #153

merged 5 commits into from
May 17, 2021

Conversation

abhi-agg
Copy link
Contributor

@abhi-agg abhi-agg commented May 17, 2021 •
edited
Loading

This PR fixes mozilla#21

  • It adds GetVersionFromFile.cmake file to compute various components of version information (e.g. Major, Minor, Patch, Git SHA etc.)
  • Adds project_version.js.in and project_version.h.in files that are configured using version information (computed by GetVersionFromFile.cmake)
    • One is for appending version info in Wasm artifacts and other is supposed to be used in native binaries
  • Bumps the version of this repo
    • The version is bumped to be in consistent with it's use in extension
  • It doesn't fix Have version information baked into executable for regression-tests mapping #82 but provides everything to fix it. All that is needed to close this one is to call the function bergamotBuildVersion to supersede version info of marian in native binaries of this repo

@abhi-agg abhi-agg changed the title Bake version info Bake version info in wasm artifacts May 17, 2021
@abhi-agg abhi-agg changed the title Bake version info in wasm artifacts Introduced Versioning machinary for wasm and native artifacts May 17, 2021
@abhi-agg abhi-agg changed the title Introduced Versioning machinary for wasm and native artifacts Introduced Versioning mechanism for wasm and native artifacts May 17, 2021
@abhi-agg
Generate project version file for native builds
4aa01f5 
 - The header file exposes a function that provides version information
   for native binaries
@abhi-agg
Bumped version to 0.3.0
4062c09 
 - This brings the version info in sync with the various releases
   of extension
@abhi-agg abhi-agg merged commit 067076f into browsermt:main May 17, 2021
@abhi-agg abhi-agg deleted the bake-version-info branch May 17, 2021 17:35
@motin motin mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerinphilip jerinphilip jerinphilip approved these changes

@andrenatal andrenatal andrenatal approved these changes

@XapaJIaMnu XapaJIaMnu XapaJIaMnu approved these changes

@motin motin Awaiting requested review from motin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@abhi-agg @jerinphilip @andrenatal @XapaJIaMnu