Cleanup API: Refactor request on-complete transition #80
Conversation
Conflicts: src/translator/response.cpp -> Bringing to sync with ByteArray updates src/translator/response.h -> Bringing to sync with ByteArray updates
We however have Histories in constructor, which we will remove out of the way soon.
jerinphilip
changed the title
jerinphilip
changed the title
jerinphilip
changed the title
…entence is happening
|
One concern about friends: can we mock out the system? It can be useful for users to be able to make their own response object for testing purposes. |
|
|
||
| QualityScoreType qualityScoreType{QualityScoreType::FREE}; | ||
| ConcatStrategy concatStrategy{ConcatStrategy::FAITHFUL}; | ||
| }; |
There was a problem hiding this comment.
@kpu Removed the Options in favour of a cpp struct, if something needs to stay/go among members or requires rename etc please let know.
We're looking at collapse of TranslationRequest and ResponseOptions. I'm deferring collapse here to avoid editing bindings.
Well, was easy deleting a bunch of lines of code to get things to work.
|
Please treat this as an explicit request to expedite merge @abhi-agg, @XapaJIaMnu, @kpu.
|
| FREE, | ||
|
|
||
| /// An expensive quality-score that runs additional computations to determine | ||
| /// quality of an output. | ||
| EXPENSIVE |
There was a problem hiding this comment.
Just adding that we probably would want to expose these scores at different text granularity as well. e.g. Word level, Sentence level. But we can update this enum later once we do more experimentation 👍
(WIP Rework of the
Request -> Responsetransition process)Over here we're not in the small PR making business, we're in moving source from complete to more complete stages business, leaving intermediates stable.
To simplify diff - merge #85 which provides essential bugfixes for what would previously be undefined behaviour, followed by #79 which requires the bugfixes and eliminates the usage of history.
(Edit: This is untangled now)
Incorporating both the above, what this PR does is abstract Request -> Response transition using ResponseBuilder.
There are the last few changes that can be moved to a separate collapse PR. behind this, will do by git-magic if required. The structures operated are documented as edits happen, so this PR also includes documentation changes.
We have big PR, yet again.