-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup API: Refactor request on-complete transition #80
Commits on Mar 31, 2021
-
Removes vocabs and propogates fixes for breaks
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 138a032 - Browse repository at this point
Copy the full SHA 138a032View commit details -
Merge branch 'main' into jp/marian-decoder-new-output-collector
Conflicts: src/translator/response.cpp -> Bringing to sync with ByteArray updates src/translator/response.h -> Bringing to sync with ByteArray updates
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 457fc69 - Browse repository at this point
Copy the full SHA 457fc69View commit details -
Prettify diff: Undoing comment shuffles due to merge conflict edits
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 28eb098 - Browse repository at this point
Copy the full SHA 28eb098View commit details -
20% of time actual work, 80% prettifying diff
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 2a6b5b2 - Browse repository at this point
Copy the full SHA 2a6b5b2View commit details -
We however have Histories in constructor, which we will remove out of the way soon.
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 63da9bd - Browse repository at this point
Copy the full SHA 63da9bdView commit details -
First draft of ResponseBuilder
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for f6fbc81 - Browse repository at this point
Copy the full SHA f6fbc81View commit details -
Jerin Philip committed
Mar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 4fe562f - Browse repository at this point
Copy the full SHA 4fe562fView commit details -
Duplicating functions for surgery at Service
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 208757c - Browse repository at this point
Copy the full SHA 208757cView commit details -
Cut Service, Request open to move ResponseBuilder in
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for e5422c4 - Browse repository at this point
Copy the full SHA e5422c4View commit details -
Surgery works! No more broken promises!
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 38f3439 - Browse repository at this point
Copy the full SHA 38f3439View commit details -
Probably overdoing appendSentence on annotation
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for ebe9839 - Browse repository at this point
Copy the full SHA ebe9839View commit details -
Transplant: ResponseBuilder new flow in
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 0201efc - Browse repository at this point
Copy the full SHA 0201efcView commit details -
Applies output collector removal as a single commit
Jerin Philip committedMar 31, 2021 Configuration menu - View commit details
-
Copy full SHA for 5d70aa2 - Browse repository at this point
Copy the full SHA 5d70aa2View commit details
Commits on Apr 1, 2021
-
Changing Annotation to adhere to [begin, end)
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for ba03154 - Browse repository at this point
Copy the full SHA ba03154View commit details -
Stronger unit tests on sentences + num words, num sentences
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for a315dc0 - Browse repository at this point
Copy the full SHA a315dc0View commit details -
Hotfix with empty string view from EOS
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for 0239a5b - Browse repository at this point
Copy the full SHA 0239a5bView commit details -
No more absolving empty-sentence; Added tests now defined behaviour
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for 4970a62 - Browse repository at this point
Copy the full SHA 4970a62View commit details -
Uncommenting important section in unit test
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for 7e2b664 - Browse repository at this point
Copy the full SHA 7e2b664View commit details -
Ensure empty string view default, beginning at end so marker points
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for d8d89f3 - Browse repository at this point
Copy the full SHA d8d89f3View commit details -
Further strengthen and comment unit-tests, mark exactly where empty s…
…entence is happening
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for f10d6d2 - Browse repository at this point
Copy the full SHA f10d6d2View commit details -
Changing Annotation to adhere to [begin, end)
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for b86db66 - Browse repository at this point
Copy the full SHA b86db66View commit details -
Stronger unit tests on sentences + num words, num sentences
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for 095fde7 - Browse repository at this point
Copy the full SHA 095fde7View commit details -
Hotfix with empty string view from EOS
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for ff5d61e - Browse repository at this point
Copy the full SHA ff5d61eView commit details -
No more absolving empty-sentence; Added tests now defined behaviour
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for f43324a - Browse repository at this point
Copy the full SHA f43324aView commit details -
Uncommenting important section in unit test
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for da43a85 - Browse repository at this point
Copy the full SHA da43a85View commit details -
Ensure empty string view default, beginning at end so marker points
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for 325b2cc - Browse repository at this point
Copy the full SHA 325b2ccView commit details -
Further strengthen and comment unit-tests, mark exactly where empty s…
…entence is happening
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for 6947dc4 - Browse repository at this point
Copy the full SHA 6947dc4View commit details -
Merge branch 'main' of github.com:browsermt/bergamot-translator into …
…jp/strengthen-annotation
Jerin Philip committedApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for 83e3290 - Browse repository at this point
Copy the full SHA 83e3290View commit details
Commits on Apr 2, 2021
-
Merge branch 'jp/strengthen-annotation' into jp/response-builder
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 82b87bb - Browse repository at this point
Copy the full SHA 82b87bbView commit details -
Merge branch 'jp/marian-decoder-new-output-collector' into jp/respons…
…e-builder
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 2125106 - Browse repository at this point
Copy the full SHA 2125106View commit details -
Remove marian entities from Response
Towards #77. Response previously required marian-deep objects like histories and vocabs for construction. It has been decided that this structure needs to be exposed and should not have marian-internals. This commit is the final nail in the coffin of Response as a marian object concept. The construction responsiblity of Response is now moved to a ResponseBuilder class.
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for cb48c79 - Browse repository at this point
Copy the full SHA cb48c79View commit details -
Sanitize Request constructor and document properly
Towards #77. Reduces Request to require only (Id, Segments, ResponseBuilder). Request is an internal structure for Service and *will not be* exposed. However, the constructor was in fact dreadful and can now be cleaned up to simplify that ResponseBuilder nicely abstracts away the transition process from Request -> Response.
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 62d022c - Browse repository at this point
Copy the full SHA 62d022cView commit details -
See the struggle turning autoformat off and prettifying diff ugghhh
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 512cc3d - Browse repository at this point
Copy the full SHA 512cc3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b63334b - Browse repository at this point
Copy the full SHA b63334bView commit details -
Jerin Philip committed
Apr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 14881dd - Browse repository at this point
Copy the full SHA 14881ddView commit details -
Further improves docs, makes docs more doxygen compatible
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for e388963 - Browse repository at this point
Copy the full SHA e388963View commit details -
Improve docs for Service external API
Towards #77. We improve doxygen compatible documentation for the external API exposed by Service. There are constructors using marian internal structures (like Options). But there is also a provision of a string (current Unified API subsitute for Options) based constructor and should suffice for a client who wants to not know of marian internals.
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 26ed203 - Browse repository at this point
Copy the full SHA 26ed203View commit details -
Doxygen prettify Service and Request documentation
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 42e1ddc - Browse repository at this point
Copy the full SHA 42e1ddcView commit details -
Constructs to make Response members optional
Towards #77. Brings in the concept of ResponseOptions, which should be the intended outcome of TranslationRequest, providing additional options along with the source string describing how to construct Response. It's currently typedef-ed to Ptr<marian::Options>, and subject to change if and when UnifiedAPI can bring it's own proper equivalent. Through options, ResponseBuilder now has if-guards to construct QualityScores or Alignments making it a no-op if the options are unset, bringing in the desired feature, albeit with a reinvented wheel structure which is not improper.
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 8f2e84e - Browse repository at this point
Copy the full SHA 8f2e84eView commit details -
Jerin Philip committed
Apr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 41a27c5 - Browse repository at this point
Copy the full SHA 41a27c5View commit details -
Set default options with sane values
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for b83026d - Browse repository at this point
Copy the full SHA b83026dView commit details -
Reduce redundancy; default is thin Response
Service::translate(...) calls Service::translateWithOptions(...) now reducing redundancy in the source-code. The default options are configured to no-alignments and no quality-scores, bringing down runtime by about 30s on WNGT20 set. service-cli is adjusted to have options so the alignment and quality tests are still functional.
Jerin Philip committedApr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for b8c1932 - Browse repository at this point
Copy the full SHA b8c1932View commit details -
Jerin Philip committed
Apr 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 6476519 - Browse repository at this point
Copy the full SHA 6476519View commit details
Commits on Apr 3, 2021
-
We accept TranslationRequest now, and vector<text>
Towards #77. - What was earlier translateWithOptions is now renamed to translate, making it a method overload based on arguments. - A new translateMultiple is provided, which is blocking. This allows the browser to sent separate vector<text> which is queued as a whole, but each text maps to a Request each for which there is a Response. This is closer to what exists in TranslationModel as of now, except there are speed gains from properly batching. translateMultiple accepts TranslationRequest as well, although it does nothing with it.
Jerin Philip committedApr 3, 2021 Configuration menu - View commit details
-
Copy full SHA for a5501da - Browse repository at this point
Copy the full SHA a5501daView commit details -
Adding comments to flow, some doc improvements
Jerin Philip committedApr 3, 2021 Configuration menu - View commit details
-
Copy full SHA for 487bfe7 - Browse repository at this point
Copy the full SHA 487bfe7View commit details -
Update TranslationModel to boost speed
Towards #77. This updates TranslationModel to use the new Service::translateMultiple(...) API to efficiently pack batches by compiling multiple Requests and using only using one translate-dispatch call for all Requests. Due to changes in batching/ordering and consequently difference in approximations after quantization, the outputs are now different from those earlier (breaking bergamot-translator-app regression-tests) but correct nonetheless (regression-tests output now need updating).
Jerin Philip committedApr 3, 2021 Configuration menu - View commit details
-
Copy full SHA for 32285aa - Browse repository at this point
Copy the full SHA 32285aaView commit details
Commits on Apr 7, 2021
-
First draft of ResponseBuilder
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for c053d2e - Browse repository at this point
Copy the full SHA c053d2eView commit details -
Jerin Philip committed
Apr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 62cbd5e - Browse repository at this point
Copy the full SHA 62cbd5eView commit details -
Duplicating functions for surgery at Service
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for f1a3f79 - Browse repository at this point
Copy the full SHA f1a3f79View commit details -
Cut Service, Request open to move ResponseBuilder in
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for e7cb458 - Browse repository at this point
Copy the full SHA e7cb458View commit details -
Surgery works! No more broken promises!
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 99a4667 - Browse repository at this point
Copy the full SHA 99a4667View commit details -
Probably overdoing appendSentence on annotation
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 773f721 - Browse repository at this point
Copy the full SHA 773f721View commit details -
Transplant: ResponseBuilder new flow in
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 828c6da - Browse repository at this point
Copy the full SHA 828c6daView commit details -
Remove marian entities from Response
Towards #77. Response previously required marian-deep objects like histories and vocabs for construction. It has been decided that this structure needs to be exposed and should not have marian-internals. This commit is the final nail in the coffin of Response as a marian object concept. The construction responsiblity of Response is now moved to a ResponseBuilder class.
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for a4be691 - Browse repository at this point
Copy the full SHA a4be691View commit details -
Sanitize Request constructor and document properly
Towards #77. Reduces Request to require only (Id, Segments, ResponseBuilder). Request is an internal structure for Service and *will not be* exposed. However, the constructor was in fact dreadful and can now be cleaned up to simplify that ResponseBuilder nicely abstracts away the transition process from Request -> Response.
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for e7197a9 - Browse repository at this point
Copy the full SHA e7197a9View commit details -
See the struggle turning autoformat off and prettifying diff ugghhh
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for ed9b83f - Browse repository at this point
Copy the full SHA ed9b83fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 583c343 - Browse repository at this point
Copy the full SHA 583c343View commit details -
Jerin Philip committed
Apr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 4a43662 - Browse repository at this point
Copy the full SHA 4a43662View commit details -
Further improves docs, makes docs more doxygen compatible
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 2932d53 - Browse repository at this point
Copy the full SHA 2932d53View commit details -
Improve docs for Service external API
Towards #77. We improve doxygen compatible documentation for the external API exposed by Service. There are constructors using marian internal structures (like Options). But there is also a provision of a string (current Unified API subsitute for Options) based constructor and should suffice for a client who wants to not know of marian internals.
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for b79c1bc - Browse repository at this point
Copy the full SHA b79c1bcView commit details -
Doxygen prettify Service and Request documentation
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for c884e51 - Browse repository at this point
Copy the full SHA c884e51View commit details -
Constructs to make Response members optional
Towards #77. Brings in the concept of ResponseOptions, which should be the intended outcome of TranslationRequest, providing additional options along with the source string describing how to construct Response. It's currently typedef-ed to Ptr<marian::Options>, and subject to change if and when UnifiedAPI can bring it's own proper equivalent. Through options, ResponseBuilder now has if-guards to construct QualityScores or Alignments making it a no-op if the options are unset, bringing in the desired feature, albeit with a reinvented wheel structure which is not improper.
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 57d1d26 - Browse repository at this point
Copy the full SHA 57d1d26View commit details -
Jerin Philip committed
Apr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for f15b717 - Browse repository at this point
Copy the full SHA f15b717View commit details -
Set default options with sane values
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for fafce99 - Browse repository at this point
Copy the full SHA fafce99View commit details -
Reduce redundancy; default is thin Response
Service::translate(...) calls Service::translateWithOptions(...) now reducing redundancy in the source-code. The default options are configured to no-alignments and no quality-scores, bringing down runtime by about 30s on WNGT20 set. service-cli is adjusted to have options so the alignment and quality tests are still functional.
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for fd9d2c4 - Browse repository at this point
Copy the full SHA fd9d2c4View commit details -
Jerin Philip committed
Apr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for c7400f6 - Browse repository at this point
Copy the full SHA c7400f6View commit details -
We accept TranslationRequest now, and vector<text>
Towards #77. - What was earlier translateWithOptions is now renamed to translate, making it a method overload based on arguments. - A new translateMultiple is provided, which is blocking. This allows the browser to sent separate vector<text> which is queued as a whole, but each text maps to a Request each for which there is a Response. This is closer to what exists in TranslationModel as of now, except there are speed gains from properly batching. translateMultiple accepts TranslationRequest as well, although it does nothing with it.
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 5bf29c1 - Browse repository at this point
Copy the full SHA 5bf29c1View commit details -
Adding comments to flow, some doc improvements
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 583fce6 - Browse repository at this point
Copy the full SHA 583fce6View commit details -
Update TranslationModel to boost speed
Towards #77. This updates TranslationModel to use the new Service::translateMultiple(...) API to efficiently pack batches by compiling multiple Requests and using only using one translate-dispatch call for all Requests. Due to changes in batching/ordering and consequently difference in approximations after quantization, the outputs are now different from those earlier (breaking bergamot-translator-app regression-tests) but correct nonetheless (regression-tests output now need updating).
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 3fb44bd - Browse repository at this point
Copy the full SHA 3fb44bdView commit details -
Updating marian-dev, looks like submodules are a pain
Jerin Philip committedApr 7, 2021 Configuration menu - View commit details
-
Copy full SHA for d0a907e - Browse repository at this point
Copy the full SHA d0a907eView commit details
Commits on Apr 15, 2021
-
Merge branch 'main' into jp/response-builder
Jerin Philip committedApr 15, 2021 Configuration menu - View commit details
-
Copy full SHA for 52e0095 - Browse repository at this point
Copy the full SHA 52e0095View commit details
Commits on Apr 16, 2021
-
Merge branch 'main' into jp/response-builder
Jerin Philip committedApr 16, 2021 Configuration menu - View commit details
-
Copy full SHA for 2929de6 - Browse repository at this point
Copy the full SHA 2929de6View commit details
Commits on Apr 21, 2021
-
Merge branch 'main' into jp/response-builder
Jerin Philip committedApr 21, 2021 Configuration menu - View commit details
-
Copy full SHA for b5363b8 - Browse repository at this point
Copy the full SHA b5363b8View commit details -
Merge branch 'jp/response-builder' of github.com:browsermt/bergamot-t…
…ranslator into jp/response-builder
Jerin Philip committedApr 21, 2021 Configuration menu - View commit details
-
Copy full SHA for dfde262 - Browse repository at this point
Copy the full SHA dfde262View commit details -
Printer: Consolidate printing Response utils at one place
Jerin Philip committedApr 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 0dc0cae - Browse repository at this point
Copy the full SHA 0dc0caeView commit details -
Jerin Philip committed
Apr 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 666b15d - Browse repository at this point
Copy the full SHA 666b15dView commit details -
cleaning a few unnecessary functions
Jerin Philip committedApr 21, 2021 Configuration menu - View commit details
-
Copy full SHA for dbad655 - Browse repository at this point
Copy the full SHA dbad655View commit details
Commits on Apr 22, 2021
-
Removing now empty response.cpp
Jerin Philip committedApr 22, 2021 Configuration menu - View commit details
-
Copy full SHA for f7c82e3 - Browse repository at this point
Copy the full SHA f7c82e3View commit details -
Merge branch 'main' into jp/response-builder
Jerin Philip committedApr 22, 2021 Configuration menu - View commit details
-
Copy full SHA for c2f8790 - Browse repository at this point
Copy the full SHA c2f8790View commit details -
Revert "cleaning a few unnecessary functions"
This reverts commit dbad655.
Jerin Philip committedApr 22, 2021 Configuration menu - View commit details
-
Copy full SHA for 01aeaa0 - Browse repository at this point
Copy the full SHA 01aeaa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6abad1c - Browse repository at this point
Copy the full SHA 6abad1cView commit details -
Revert "Printer: Consolidate printing Response utils at one place"
This reverts commit 0dc0cae.
Jerin Philip committedApr 22, 2021 Configuration menu - View commit details
-
Copy full SHA for dcf8491 - Browse repository at this point
Copy the full SHA dcf8491View commit details -
Merge branch 'jp/response-builder' of github.com:browsermt/bergamot-t…
…ranslator into jp/response-builder
Jerin Philip committedApr 22, 2021 Configuration menu - View commit details
-
Copy full SHA for 7b1f18a - Browse repository at this point
Copy the full SHA 7b1f18aView commit details -
Merge branch 'main' into jp/response-builder
Jerin Philip committedApr 22, 2021 Configuration menu - View commit details
-
Copy full SHA for 4a83104 - Browse repository at this point
Copy the full SHA 4a83104View commit details -
Adding ResponseOptions to service-cli-bytearray
Jerin Philip committedApr 22, 2021 Configuration menu - View commit details
-
Copy full SHA for ca48e9b - Browse repository at this point
Copy the full SHA ca48e9bView commit details
Commits on Apr 23, 2021
-
Undoing service-cli autoformat
Jerin Philip committedApr 23, 2021 Configuration menu - View commit details
-
Copy full SHA for ca9e6c5 - Browse repository at this point
Copy the full SHA ca9e6c5View commit details -
undoing style stuff on service.cpp
Jerin Philip committedApr 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 6dd5f29 - Browse repository at this point
Copy the full SHA 6dd5f29View commit details
Commits on Apr 26, 2021
-
ResponseOptions is now a struct with default construction
Jerin Philip committedApr 26, 2021 Configuration menu - View commit details
-
Copy full SHA for ee398d8 - Browse repository at this point
Copy the full SHA ee398d8View commit details -
Jerin Philip committed
Apr 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 959be6c - Browse repository at this point
Copy the full SHA 959be6cView commit details -
Jerin Philip committed
Apr 26, 2021 Configuration menu - View commit details
-
Copy full SHA for bd0e20f - Browse repository at this point
Copy the full SHA bd0e20fView commit details -
Elaborating alignmentThreshold documentation
Jerin Philip committedApr 26, 2021 Configuration menu - View commit details
-
Copy full SHA for d000d8a - Browse repository at this point
Copy the full SHA d000d8aView commit details -
Remove move constructor; Using default
Jerin Philip committedApr 26, 2021 Configuration menu - View commit details
-
Copy full SHA for e33a22e - Browse repository at this point
Copy the full SHA e33a22eView commit details -
Remove constructors from Response
Well, was easy deleting a bunch of lines of code to get things to work.
Jerin Philip committedApr 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 7c8157b - Browse repository at this point
Copy the full SHA 7c8157bView commit details -
Merge branch 'main' into jp/response-builder
Jerin Philip committedApr 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 7a5acbb - Browse repository at this point
Copy the full SHA 7a5acbbView commit details -
C++ style initializer list for struct
Jerin Philip committedApr 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 8a61d79 - Browse repository at this point
Copy the full SHA 8a61d79View commit details -
Manually fixing merge submodule weirdness
Jerin Philip committedApr 26, 2021 Configuration menu - View commit details
-
Copy full SHA for b8b1b19 - Browse repository at this point
Copy the full SHA b8b1b19View commit details