Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize zero-padded version numbers #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Normalize zero-padded version numbers #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/browserslist_useragent/version_normalizer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ def call
return nil if agent_version.major.nil?

[
agent_version.major,
agent_version.minor || 0,
agent_version.patch || 0
agent_version.major.to_i,
agent_version.minor.to_i || 0,
agent_version.patch.to_i || 0
].join('.')
end
end
Expand Down
17 changes: 16 additions & 1 deletion spec/browserslist_useragent/resolver_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def resolve_user_agent(user_agent)
end

it 'resolves all browsers in iOS to safari with correct platform version' do
# chome on iOS
# chrome on iOS
expect(
resolve_user_agent(
'Mozilla/5.0 (iPhone; CPU iPhone OS 10_3_0 like Mac OS X) AppleWebKit/603.3.8 (KHTML, like Gecko) CriOS/60.0.0.0 Mobile/14E5239e Safari/602.1'
Expand Down Expand Up @@ -75,6 +75,13 @@ def resolve_user_agent(user_agent)
)
).to eq(family: 'Chrome', version: '41.0.228')

# chrome with a zero-padded version
expect(
resolve_user_agent(
'Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/535.14.61 (KHTML, like Gecko) Chrome/53.5.0289.5916 Safari/534.43'
)
).to eq(family: 'Chrome', version: '53.5.289')

# headless
expect(
resolve_user_agent(
Expand Down Expand Up @@ -119,5 +126,13 @@ def resolve_user_agent(user_agent)
)
).to eq(family: 'Firefox', version: '44.0.0')
end

it 'resolves opera properly' do
expect(
resolve_user_agent(
'Opera/9.80 (Windows NT 6.1; U; es-ES) Presto/2.9.181 Version/12.00'
)
).to eq(family: 'Opera', version: '12.0.0')
end
end
end