-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable --force-upload to upload npm packages #266
Changes from 9 commits
3501a1c
b003410
d0a6851
1da9162
0b9e87d
c96fc94
cdcf071
540b955
34e3806
6cf33d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,14 +105,15 @@ let reportGenerator = (bsConfig, buildId, args, rawArgs, cb) => { | |
let messageType = null; | ||
let errorCode = null; | ||
let build; | ||
|
||
if (err) { | ||
message = err; | ||
messageType = Constants.messageTypes.ERROR; | ||
errorCode = 'api_failed_build_report'; | ||
|
||
logger.error('Generating the build report failed.'); | ||
logger.error(message); | ||
logger.error(utils.formatRequest(err, resp, body)); | ||
|
||
utils.sendUsageReport(bsConfig, args, message, messageType, errorCode, null, rawArgs); | ||
return; | ||
|
@@ -135,6 +136,7 @@ let reportGenerator = (bsConfig, buildId, args, rawArgs, cb) => { | |
message = Constants.userMessages.API_DEPRECATED; | ||
logger.info(message); | ||
} | ||
logger.error(utils.formatRequest(err, resp, body)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove this |
||
} else if (resp.statusCode === 422) { | ||
messageType = Constants.messageTypes.ERROR; | ||
errorCode = 'api_failed_build_generate_report'; | ||
|
@@ -146,6 +148,7 @@ let reportGenerator = (bsConfig, buildId, args, rawArgs, cb) => { | |
response = {message: message}; | ||
} | ||
logger.error(response.message); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove this..this is redundant after statement we added |
||
logger.error(utils.formatRequest(err, resp, body)); | ||
} else if (resp.statusCode != 200) { | ||
messageType = Constants.messageTypes.ERROR; | ||
errorCode = 'api_failed_build_generate_report'; | ||
|
@@ -160,6 +163,7 @@ let reportGenerator = (bsConfig, buildId, args, rawArgs, cb) => { | |
message = Constants.userMessages.BUILD_GENERATE_REPORT_FAILED.replace('<build-id>', buildId); | ||
logger.error(message); | ||
} | ||
logger.error(utils.formatRequest(err, resp, body)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. move this to line 164 and remove what's there on 164 |
||
} else { | ||
messageType = Constants.messageTypes.SUCCESS; | ||
message = `Report for build: ${buildId} was successfully created.`; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this