enable --force-upload to upload npm packages #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagpalkaran95
previously approved these changes
Mar 4, 2022
nagpalkaran95
requested changes
Mar 8, 2022
bin/helpers/build.js
Outdated
| @@ -24,6 +25,7 @@ const createBuild = (bsConfig, zip) => { | |||
|
|
|||
| request.post(options, function (err, resp, body) { | |||
| if (err) { | |||
| logger.info(utils.formatRequest(err, resp, body)); | |||
There was a problem hiding this comment.
logger.error in case of errors
nagpalkaran95
changed the title
nagpalkaran95
requested changes
Mar 8, 2022
bin/helpers/reporterHTML.js
Outdated
| @@ -105,14 +105,15 @@ let reportGenerator = (bsConfig, buildId, args, rawArgs, cb) => { | |||
| let messageType = null; | |||
| let errorCode = null; | |||
| let build; | |||
|
|
|||
|
|
|||
| if (err) { | |||
| message = err; | |||
| messageType = Constants.messageTypes.ERROR; | |||
| errorCode = 'api_failed_build_report'; | |||
|
|
|||
| logger.error('Generating the build report failed.'); | |||
| logger.error(message); | |||
bin/helpers/reporterHTML.js
Outdated
| @@ -135,6 +136,7 @@ let reportGenerator = (bsConfig, buildId, args, rawArgs, cb) => { | |||
| message = Constants.userMessages.API_DEPRECATED; | |||
| logger.info(message); | |||
| } | |||
| logger.error(utils.formatRequest(err, resp, body)); | |||
bin/helpers/reporterHTML.js
Outdated
| @@ -146,6 +148,7 @@ let reportGenerator = (bsConfig, buildId, args, rawArgs, cb) => { | |||
| response = {message: message}; | |||
| } | |||
| logger.error(response.message); | |||
There was a problem hiding this comment.
remove this..this is redundant after statement we added
bin/helpers/reporterHTML.js
Outdated
| @@ -160,6 +163,7 @@ let reportGenerator = (bsConfig, buildId, args, rawArgs, cb) => { | |||
| message = Constants.userMessages.BUILD_GENERATE_REPORT_FAILED.replace('<build-id>', buildId); | |||
| logger.error(message); | |||
| } | |||
| logger.error(utils.formatRequest(err, resp, body)); | |||
There was a problem hiding this comment.
move this to line 164 and remove what's there on 164
nagpalkaran95
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description