-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes issue #34 - put on hold #53
Conversation
While it solves the creation of scripts issue it generates display issues of menu items. |
@ClaudiaFrank Do you mean the issue from #20:
? |
PythonScript/src/PythonScript.cpp
Outdated
|
||
OPENFILENAMEA ofn; | ||
memset(&ofn, 0, sizeof(OPENFILENAMEA)); | ||
OPENFILENAMEW ofn; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be possible to use the version OPENFILENAME, GetSaveFileName, CreateFile without the W extension as we are building with Unicode and in this case it is anyhow mapped to the W versions, see e.g. docu of https://msdn.microsoft.com/en-us/library/windows/desktop/ms646839(v=vs.85).aspx
at the end of the page in requirements
Kind of yes, it is a little bit strange, it does work under subdirectories and in main menu when using but running it by clicking the item under subdirectory corrupts the and clicking the ÜberÄÖß.py under main menu does NOT corrupt the Run Previous Script menuitem |
Seems to be caused by: Need to be tested with e.g. |
I guess/assume I understood what the problem is. I will follow up on this and see if this is really the case. |
This is still not perfect, even so menu issues should have been solved another issue raised Left, the white background = current situation (without unicode path support) In case that one wants to use the extended chars to be displayed as "error text" it is needed |
See PR #60, so this one could be closed, as discussed offline |
No description provided.