Implemented damage sum #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brugal
reviewed
Mar 9, 2023
| @@ -3313,3 +3313,16 @@ void CG_ClearFxExternalForces (void) | |||
| } | |||
| } | |||
| #endif | |||
|
|
|||
|
|
|||
| void CG_HideDamagePlums (int client, int weapon) { | |||
There was a problem hiding this comment.
Thanks. Is CG_HideDamagePlums() just used to hide self damage? Why not just avoid adding them at all?
There was a problem hiding this comment.
Is CG_HideDamagePlums() just used to hide self damage?
No. It used for different case. For example we have 3 plasma hits. Without using CG_HideDamagePlums() and enabled damage sum hack it will show 3 damage plums. 20, 40 and 60. When all these damage plums are shown, it is hardly readable how many damage dealt.
When usin CG_HideDamagePlums, on second hit it will show damage plum with "40" and hide previous damage plum "20". On third hit it will show damage plum "60" and hide previous damage plum "40".
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included readme with note.
Example: https://www.youtube.com/watch?v=rCPH63uQCKQ