Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Add bower support #21

Merged
merged 2 commits into from
May 8, 2013
Merged

Add bower support #21

merged 2 commits into from
May 8, 2013

Conversation

iki
Copy link
Contributor

@iki iki commented May 7, 2013

used to register the package with bower:
bower register auto-reload-brunch git://github.com/brunch/auto-reload-brunch.git

now it's possible to:
bower install auto-reload-brunch
and have it automatically compiled by brunch, e.g. in config.coffee/files.javascripts.joinTo:

        'js/vendor-develop.js': /// # additional vendor lib for development
          ^vendor.*[\\/](
              'auto-reload'
            )\.js$
          ///

@paulmillr
Copy link
Contributor

not sure about this.

brunch loads by default all npm plugin vendor files. what’s need in this?

@iki
Copy link
Contributor Author

iki commented May 8, 2013

it's not related to the plugin lib/index.js delivered by npm and loaded automatically by brunch

it makes client-side vendor/auto-reload.js deliverable by bower

use case:

  • in a development env for a client-side app, we source an additional js/vendor-develop.js lib compiled by brunch and also js/auto-reload.js taken from assets
  • so while auto-reload is a vendor lib, it's not treated like that, which has some cons:
    • it has to be in repository
    • it's not updated on bower install or bower update
    • it's not compiled to js/vendor-develop.js, where it should belong

simple solution:

  • treat auto-reload as any other vendor lib (like outlined above) ... which needed to make it instalable via bower

paulmillr added a commit that referenced this pull request May 8, 2013
@paulmillr paulmillr merged commit a84d43d into brunch:master May 8, 2013
@iki iki deleted the feature/bower-support branch May 8, 2013 17:17
@paulmillr
Copy link
Contributor

@iki do you need composer support? bower and component are cool, but composer (php) in js project is weird

@iki
Copy link
Contributor Author

iki commented May 12, 2013

no, I don't need it, it's just habit to add its package info as well, ie.
for others who might want to use the package with composer (e.g those weird
php guys :) ...of course, it can be left out until anyone actually needs
it, if at all

On Sat, May 11, 2013 at 10:48 PM, Paul Miller notifications@github.comwrote:

@iki https://github.com/iki do you need composer support? bower and
component are cool, but composer (php) in js project is weird


Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-17767177
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants