This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to how CSS and JS files are detected for live injection has broken the behavior for probably most projects. This is specifically in relation to PR #67 and commit 8239eb9. The files being matched are output files, which in a default brunch project will be
public/app.css
. However, the default glob*.css
will fail to match against this pattern due to the directory in the path.Due to this, all CSS changes are causing a full page reload instead of injection, which is by far the coolest features of this module.
I can think of two ways to revert the behavior to match the old behavior of
sysPath.extname(file.path) === '.css'
:**/*.css
/.css$/
I did a comparison of the two, and regex is faster, so I went with that for this PR.
For now a workaround is to add this to your brunch-config.js:
I also updated the tests to more reflect a typical path for the module.
Thanks,
Nate