This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Fixes Multi-Socket Reload Bug #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket close event handler appears to have a bug in it. As far as I know, the only acceptable first parameter to `Array::splice` is a Number (as opposed to an object as seen in [line 65 of index.js(https://github.com/brunch/auto-reload-brunch/blob/673350f86ea4c28efd2a9379e03ca6e24c25a5f1/index.js#L65)]). Specifying an object as the first parameter appears to always splice the first element off. This pull request fixes this issue by using `Array::indexOf` to look up the index of the socket first. Some steps to illustrate this bug: 1. Start your brunch server. 2. Load up the page in Chrome. 3. Load up the page in Firefox. 4. Make a change and see that both browsers refresh. 5. Close Firefox. This will cause Chrome's socket to to be popped off of the `conns` array instead of Firefox's. 6. Make a change and see that Chrome is no longer responding.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket close event handler appears to have a bug in it. As far as I know, the only acceptable first parameter to
Array::spliceis a Number (as opposed to an object as seen in line 65 of index.js.)Specifying an object as the first parameter appears to always splice the first element off. This pull request fixes this issue by using
Array::indexOfto look up the index of the socket first.Some steps to illustrate this bug:
connsarray instead of Firefox's.