This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Allow the host to be set from the brunch config. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * Setting the host in the html will leak into the production code. This change addresses the need by: * Updated compilation to set host if set in the brunch config. Side effects: * If the host is set in the brunch config, then it cannot be overriden.
|
Thanks! |
|
Sure thing. Glad I could help. Do you have any idea when a new version will be released on npm? I'd like to point back at the main package rather than our fork. |
|
@paulmillr any chance you can release a new version with these changes on npm? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This change addresses the need by:
Side effects: