Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Update ncp to 0.2.6 and possibly add config options #233

Closed
swbiggart opened this issue Mar 26, 2012 · 3 comments
Closed

Update ncp to 0.2.6 and possibly add config options #233

swbiggart opened this issue Mar 26, 2012 · 3 comments

Comments

@swbiggart
Copy link

I've been having intermittent build issues where sometimes the contents of app/assets fail to be moved correctly. I still haven't narrowed down the problem, but in doing my debugging I noticed that the file permissions (owner/group) were inconsistent after ncp moves the files.

I then looked at the ncp github and saw that the issue was fixed in the most recent version 0.2.6:

AvianFlu/ncp#13

It would be nice if brunch used this newest version.

Also, ncp has the ability to use a few flags that would be helpful for debugging:

ncp [source] [dest] [--limit=concurrency limit] [--filter=filter] --stopOnErr

that would be nice if I could pass to brunch directly (instead of me hacking up source to debug)

Thanks!

@paulmillr
Copy link
Contributor

How the flags should be passed in your opinion? Maybe brunch just enable stopOnErr by default?

@swbiggart
Copy link
Author

Well, the flag I was most interested in was the --limit option, cause I thought that I was running into an issue with too many concurrent files open (which, when I realized 16 is the default, came to the conclusion that wasn't the issue).

I like the idea of stopOnErr by default, or maybe when BRUNCH_DEBUG=1 is set.

One option for setting ncp options could be in the config.coffee file, which has buildPath and other compile/asset/plugin config options.

@paulmillr
Copy link
Contributor

Fixed in 1.0.1 (npm update -g brunch).

As for stopOnErr — brunch currently doesn't stop on errors so I think it should be consistent here too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants