This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Properly support source maps with 2+ sources #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (sourceMap && sourceMap.sources) { | ||
| sourceMap.sources.forEach(path => { | ||
| const file = fileList.find(path); | ||
| const content = file && file.source || fs.readFileSync(path).toString(); |
There was a problem hiding this comment.
sometimes a file won't be on the file list (e.g. if it's _something.sass and _* files are ignored) so it's probably ok to read these synchronously
There was a problem hiding this comment.
We read those files with fcache already.
| return node; | ||
|
|
||
| // the supplied source map might contain more than one source file | ||
| const addSource = path => readFile(path).then(content => { |
There was a problem hiding this comment.
Updated to use fcache for reads
paulmillr
added a commit
that referenced
this pull request
Feb 4, 2016
Properly support source maps with 2+ sources
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which is needed to properly handle source maps for pre-processed stylesheets