LPS-95117 Add container-input-field-index attribute #1020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late need the "_PRIORITY_BUFFER" offset
The current implementation of RawMetadataProcessorImpl has conditional logic depending on the implementation class, dispatching on the result of an instanceof check (see RawMetadataProcessorImpl#saveMetadata). We cannot fix this right now without introducing API changes (e.g. by adding a new capability), so we need to do the mime type check to avoid wrapping the file entry.
…UI Modal and ClayModal
…staged model The folder that was being used is the one read directly from the exported zip file therefore it still has the repository id from the local instance which is wrong.
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test:sf |
|
ci:test:relevant |
Build started.Jenkins is currently running tests. Base Branch:Branch Name: master Job Summary:Job Link: test-portal-acceptance-pullrequest(master) For more details click here. |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 41 seconds 286 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-95117 1 Successful Jobs:For more details click here. |
|
Just started reviewing :) |
Sent from
|
Pull request submitted to brianchandotcom#73052. See changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.