LPS-107954 Only include Success page option if enabled #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or any other framework, type: git grep -B 5 -A 5 saveLastPath **.java
…ics Reports panel
…f multiPage is enabled
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
I've sent this pr on top of #1115 to avoid conflict between those :) |
|
Just started reviewing :) |
|
I'll take this so @brunobasto can enjoy Carnival ;) |
|
ci:close |
|
Thank you, @jbalsas! I’ll be sending what I have on nested fields first thing tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @brunobasto
This pr includes the ability to enable/disable the option to create success pages from the data-engine taglib
I made this commit 50c590c because it was very strange logic that it was adding the option to the dropdown when enabled was false, shouldn't it be the other way around? 🤔 Let me know if we can change this safely
Thanks!