LPS-107954, LPS-108010, LPS-109156 #85429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the value of the inputLocalized
Create component SidebarTabs to handle tabs selection
Formatting lints, and:
modules/apps/journal/journal-web/src/main/resources/META-INF/resources/js/dataEngineLayoutRendererLanguageProxy.es.js
32:27 error 'event' is defined but never used. Allowed unused args must match /^_/u. no-unused-vars
Fixes:
modules/apps/data-engine/data-engine-taglib/src/main/resources/META-INF/resources/data_layout_builder/js/components/fieldsets/Fieldsets.es.js
18:8 error 'saveDefinitionAndLayout' is defined but never used. no-unused-vars
Explained here: #149 (comment) > In general, any promise should have a catch — ideally to recover > gracefully, but even if we can't do that, we can at least refrain from > creating console spew about an unhandled promise rejection. In this case, I'm logging information about the error, but only in development mode. In production builds the logging gets stripped out.
This was referenced Feb 27, 2020
|
CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests. Comment "ci:test" to run the full PR Tester for this pull. |
|
cc @ealonso, @victorg1991 |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #85428 to resolve merge conflicts. As described there:
This is a batch of in-progress work that is protected by a feature flag, specifically
useDataEngineEditor="true"in a config file:To prevent this from snowballing further we've done some initial review here:
and I've done QA to confirm that the changes don't break related things like app-builder.