Site.domain returns 127.0.0.1 behind Nginx

[dereknutile]

Fixed an issue where site.domain returned 127.0.0.1:port# rather than the base URL in the email subject and template. This is an issue when running uwsgi/Gunicorn behind a proxy server like Nginx. Now we allow site.domain to be obtained from the database value first (if it exists) then from the url if it doesn't.

[brutasse]

Thanks for this! It looks like a proxy misconfiguration, though. I use nginx and never ran into this issue.

Do you have this in your nginx config?

proxy_set_header Host $http_host;

Looks like you touched something in success_url_name that doesn't seem related to that issue. Was that intentional?

If you could add a mention about the get_site() method in the docs it'd be great. Then I'll merge this :)

[dereknutile]

Bruno,

Good call on the nginx missing configuration setting. However, I think there may be a reason proxy_set_header wasn't set on my live server and I'm scared to change it now! ;-) Regardless, I feel there is a valid reason to check the Django sites framework for the current value.

Regarding success_url_name: I did somehow overwrite this commit: 79ffe35, it wasn't intentional. I'll fix it and add something about get_site() in the docs.

[dereknutile]

Let me know if I missed anything Bruno. -Derek

[brutasse]

@dereknutile thank you 👍