-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for divideSeriesLists function #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The build has failures for reasons unrelated to this patch. I have updated the master branch and it builds without warnings now. Could you rebase with master and address the lint issues? I also left a couple of comments.
graphite_api/functions.py
Outdated
#for dividendSeries in dividendSeriesList: | ||
for i in range(0, len(dividendSeriesList)): | ||
dividendSeries = dividendSeriesList[i] | ||
divisorSeries = divisorSeriesList[i] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid using an index: for dividentSeries, divisorSeries in zip(dividendSeriesList, divisorSeriesList):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed that in the new commit.
graphite_api/functions.py
Outdated
end -= (end - start) % step | ||
|
||
#toto | ||
#raise ValueError("%s" % repr(zip(*bothSeries))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to clean up my tests before committing :)
I have made the requested changes. The linter is still complaining about a file not concerned by this PR. |
Thanks @setaou! |
No description provided.