Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the continuous integration routine #24

Closed
bryanbraun opened this issue Feb 10, 2015 · 1 comment
Closed

Improve the continuous integration routine #24

bryanbraun opened this issue Feb 10, 2015 · 1 comment

Comments

@bryanbraun
Copy link
Owner

We currently have npm scripts in our package.json file that run automated linting via Travis CI. This is good.

Ideally we could improve this with some automated tests for AnchorJS functionality. We could do this by using PhantomJS (which is available on TravisCI), writing tests with QUnit, and connecting the pieces with Grunt, as described in this post.

The existing index.html page is a starting place for a good test page. It already has examples of headings with IDs, without IDs, and those that could generate duplicate IDs.
@bryanbraun bryanbraun mentioned this issue Mar 6, 2015
Closed
@bryanbraun bryanbraun mentioned this issue Apr 30, 2015
Merged
3 tasks
@bryanbraun
Copy link
Owner Author

This was addressed as part of version 1.0.0. Now we have integration tests written with Jasmine and run against Phantom using Karma. Closing.

bryanbraun pushed a commit that referenced this issue May 24, 2015
@nzakas
Merge pull request #24 from zpao/patch-1
28135a7 
Fix Markdown issue in 0.15 blog post
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bryanbraun