Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update createColumns() doc #193

Merged
merged 2 commits into from Feb 22, 2024

Conversation

lolcabanon
Copy link
Contributor

Added warning to avoid formatting id so that svelte-keyed will not parse it wrongly.

I added it as tip but was wondering is a warning would be better since it fails to execute.


It gave me an error while I used column_id[x] in a for loop to generate columns.

TypeError: Cannot set properties of undefined (setting '0')

Here's the full call stack :

TypeError: Cannot set properties of undefined (setting '0')
    at /home/gugul/DEV/CRCATNQ/sveltekit-demo/node_modules/.pnpm/svelte-keyed@2.0.0_svelte@4.2.11/node_modules/svelte-keyed/dist/index.js:40:59
    at Object.update (/home/gugul/DEV/CRCATNQ/sveltekit-demo/node_modules/.pnpm/svelte@4.2.11/node_modules/svelte/src/runtime/store/index.js:69:7)
    at Object.set (/home/gugul/DEV/CRCATNQ/sveltekit-demo/node_modules/.pnpm/svelte-keyed@2.0.0_svelte@4.2.11/node_modules/svelte-keyed/dist/index.js:35:16)
    at /home/gugul/DEV/CRCATNQ/sveltekit-demo/node_modules/.pnpm/svelte-headless-table@0.18.2_svelte@4.2.11/node_modules/svelte-headless-table/dist/plugins/addColumnFilters.js:67:33
...

Added warning to avoid formatting `id` so that `svelte-keyed` will parse it wrongly.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7966009360

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.766%

Totals Coverage Status
Change from base Build 7758063433: 0.0%
Covered Lines: 2616
Relevant Lines: 4570

💛 - Coveralls

@lolcabanon
Copy link
Contributor Author

After seeing the preview, I think I prefer the result like this. Tell me what you think of it!

@bryanmylee
Copy link
Owner

This is a great catch! I would've never thought to document this, thanks!

@bryanmylee bryanmylee merged commit 08dd201 into bryanmylee:main Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants