Fix addResizedColumns interaction with addGridLayout
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2399941804Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bryanmylee
force-pushed
the
fix/addResizedColumns
branch
from
1ffdb27
to
dfa03f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we support more layout options, we'll need a better way of setting the widths of columns.
Currently, addResizedColumns defines the
width,min-width, andmax-widthstyle properties for each cell. However, we may not always want to usewidthas the basis of the column resizing.This indicates that we need a form of information passing from the attributes of
addResizedColumnsto the attributes ofaddGridLayouti.e.addGridLayoutshould be able to read and modify the attributes defined byaddResizedColumns.This would close #26.