Placeholder on Criteria Editor title #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(only available if "company.security.send.password" is true)
…on now that there are more than one. Also embrace ordering from account created templates
…ject is actual default value
… part of a friendly URL
…id potential clashing
A the component takes an array of contributors, it makes more sense its name to be plural
…ors object The ContributorBuilder was printing Input hidden elements for a form, now this can move up to SegmentEdit component. This way ContributorBuilder can be used in a more flexible way
Fetching to get the number of members is perform one level up by the SegmentEdit component. ContributorBuilder consumes the state related to that operation as props. This makes ContributorBuilder component more flexible.
As ContributorBuilder becomes more flexible, it no longer uses requestMembersCountURL nor formId. Instead, it accepts a onPreviewMembers prop, and it is SegmentEdit the one handling that logic.
… a function This will allow to use this exact same process in any other component that initialize a ContributorBuilder
|
CI running here: https://github.com/dgarciasarai/liferay-portal/pull/66 |
|
Pull request submitted to brianchandotcom#74241. |
Sent from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.