This repository has been archived by the owner on Mar 21, 2020. It is now read-only.
Configurable explicit encoding as UTF-8 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to use ${record} in addition to ${tag_parts} and ${hostname} as
interpolated values for sourcetype, source and index.
Switches from the mixin to the fluent provided expander similar to
https://github.com/kazegusuri/fluent-plugin-prometheus/blob/348c112d/lib/fluent/plugin/prometheus.rb
Added various test to ensure the old values and the new values work.
Fluent is internally encoding events as ASCII-8BIT, while json is encoded as UTF-8 as default. Workaround runtime encoding errors like `Encoding::UndefinedConversionError: "\xC3" from ASCII-8BIT to UTF-8`, by adding a `coerce_to_utf8` configuration option, which encodes events to UTF-8 and replaces invalid and undefined chars. Coversion code thanks to https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/blob/dbc28575/lib/fluent/plugin/out_google_cloud.rb#L1284
|
@johanneswuerbach Just a heads-up that Github is reporting "The key that signed this is expired. GPG key ID: 74DB0F4D956CCCE3" |
brycied00d
added a commit
that referenced
this pull request
Apr 20, 2017
Configurable explicit encoding as UTF-8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fluent is internally encoding events as ASCII-8BIT, while json is encoded as
UTF-8 as default. During that implicit conversion, errors like
Encoding::UndefinedConversionError: "\xC3" from ASCII-8BIT to UTF-8mightbe raised when an event contains invalid data and the event is discarded.
This adds a
coerce_to_utf8configuration option, which encodes eventsexplicitly to UTF-8 and replaces invalid and undefined chars with a configurable
non_utf8_replacement_string.Coversion code thanks to
https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/blob/dbc28575/lib/fluent/plugin/out_google_cloud.rb#L1284
Based on #7