todo

bryntum · Jun 9, 2020 · 7264dad · 7264dad
1 parent 2b7b52e
commit 7264dad
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -26,6 +26,7 @@
 
 # misc local files
 /misc
+/tests/chrono2/todo/**/*
 
 # Libre Office lock files
 .~lock*
diff --git a/src/chrono2/Quark.ts b/src/chrono2/Quark.ts
@@ -5,7 +5,8 @@ import { Node } from "./Node.js"
 
 
 //---------------------------------------------------------------------------------------------------------------------
-// TODO benchmark if numbers are faster
+// Benchmarking showed that there's no difference when using numbers
+// v8 optimizes comparison of immutable strings to pointer comparison I guess
 export enum AtomState {
     UpToDate        = 'UpToDate',
     PossiblyStale   = 'PossiblyStale',

diff --git a/tests/benchmark/deep_changes.ts b/tests/benchmark/deep_changes.ts
@@ -167,7 +167,7 @@ export const deepChangesGenBigShared = DeepChangesChronoGraph.new({
 export const runAllDeepChanges = async () => {
     const runInfo   = await deepChangesGenSmall.measureTillMaxTime()
 
-    await deepChangesSyncSmall.measureFixed(runInfo.cyclesCount, runInfo.samples.length)
+    // await deepChangesSyncSmall.measureFixed(runInfo.cyclesCount, runInfo.samples.length)
     await deepChangesMobxSmall.measureFixed(runInfo.cyclesCount, runInfo.samples.length)
     await deepChangesChrono2Small.measureFixed(runInfo.cyclesCount, runInfo.samples.length)
 

diff --git a/tests/benchmark/shallow_changes.ts b/tests/benchmark/shallow_changes.ts
@@ -153,7 +153,7 @@ export const shallowChangesGenBig = ShallowChangesChronoGraph.new({
 export const runAllShallowChanges = async () => {
     const runInfo   = await shallowChangesGen.measureTillMaxTime()
 
-    await shallowChangesSync.measureFixed(runInfo.cyclesCount, runInfo.samples.length)
+    // await shallowChangesSync.measureFixed(runInfo.cyclesCount, runInfo.samples.length)
     await shallowChangesMobx.measureFixed(runInfo.cyclesCount, runInfo.samples.length)
     await shallowChangesChrono2.measureFixed(runInfo.cyclesCount, runInfo.samples.length)
 

diff --git a/tests/benchmark/suite.ts b/tests/benchmark/suite.ts
@@ -3,7 +3,7 @@ import { runAllDeepChanges } from "./deep_changes.js"
 import { runAllShallowChanges } from "./shallow_changes.js"
 
 export const runAll = async () => {
-    // await runAllDeepChanges()
+    await runAllDeepChanges()
     await runAllShallowChanges()
     // await runAllGraphPopulation()
 

diff --git a/tsconfig.json b/tsconfig.json
@@ -22,5 +22,6 @@
     ],
 
     "exclude" : [
+        "tests/chrono2/todo/**/*.ts"
     ]
 }