Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewer ts imports #149

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix viewer ts imports #149

merged 1 commit into from
Sep 29, 2023

Conversation

rtm516
Copy link
Contributor

@rtm516 rtm516 commented Sep 28, 2023

Fixes #143

  • Relies on Update threejs to latest #145
  • Updates @types/three to match the three package
  • Correctly imports Mapping as a type
  • Use correct path for importing FullScreenQuad

@Hacksore
Copy link
Collaborator

Hacksore commented Sep 29, 2023

@rtm516 can you please rebase and change the package version to 3.0.1?

@rtm516
Copy link
Contributor Author

rtm516 commented Sep 29, 2023

@Hacksore Actioned

@Hacksore Hacksore merged commit 8b9f8b5 into bs-community:master Sep 29, 2023
1 check passed
@Hacksore
Copy link
Collaborator

shipped in v3.0.1 🥳

@rtm516 rtm516 deleted the fix/viewer-imports branch September 29, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants