Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageObj nested objects names and creation #190

Merged
merged 10 commits into from
Oct 25, 2018
Merged

Conversation

polsm91
Copy link
Collaborator

@polsm91 polsm91 commented Oct 10, 2018

Nested IStorage weren't created properly in the StorageObj. The name given to nested IStorage objects was wrong. Sometimes accessing the nested IStorage objects created a new empty object instead of accessing the stored data in Cassandra.

Fixed by:

  • The init method properly creates the nested IStorage objects.
  • Doing a getattr retrieves the nested IStorage that existed when the make persistent was called. If setattr was called, returns the last IStorage object assigned.
  • Calling a setattr of a persistent StorageObj makes persistent the given object.
  • Calling make _persistent on a StorageObj, accesses the hecuba.istorage table to retrieve the metadata (tokens and such)
  • Added tests to verify the expected behaviour

Fixes #176 for StorageObjects

@cugni cugni merged commit 23c7e87 into master Oct 25, 2018
@cugni cugni deleted the Fix#176_NestedObjRefs branch October 25, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants