Refactor TensorNetwork to new definition
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 84.89% 84.30% -0.59%
==========================================
Files 12 9 -3
Lines 748 599 -149
==========================================
- Hits 635 505 -130
+ Misses 113 94 -19
|
mofeing
added
enhancement
added 20 commits
May 7, 2023 12:55
Co-authored-by: Jofre Vallès Muns <61060572+jofrevalles@users.noreply.github.com>
jofrevalles
reviewed
May 8, 2023
jofrevalles
requested changes
May 8, 2023
There was a problem hiding this comment.
With these two changes we don't get errors with norm and, in general, the contraction seems ok.
julia> ψ = rand(MatrixProduct{State,Open}, n = 4, p = 2, χ = 32)
TensorNetwork{MatrixProduct{State, Open}}(#tensors=4, #labels=7)
julia> norm(ψ)
0.9999999999999939
julia> A = Tensor(rand(2, 2, 2), (:i, :j, :k)); B = Tensor(rand(2, 2), (:j, :l))
2×2 Tensor{Float64, 2, Matrix{Float64}}:
0.433555 0.834031
0.459739 0.646734
julia> C = contract(A, B)
2×2×2 Tensor{Float64, 3, Array{Float64, 3}}:
[:, :, 1] =
0.559003 0.0637526
0.198716 0.576309
[:, :, 2] =
1.00909 0.107564
0.354096 1.01502
julia> labels(C)
(:i, :k, :l)
|
@jofrevalles would you mind writing a couple of tests of the errors you are finding? I'm unable to see where the problems are without code examples. |
|
Found this error. Needs to be fixed before I explore more for MPO. |
jofrevalles
requested changes
May 9, 2023
…e` type (#57) * Refactor `TensorNetwork` metadata to new parametric definition * Test `merge`, `superansatzes` * Fix `TensorNetwork` tests * Replace `metadata` access with implicit `getproperty` calls * Fix `NamedTuple`'s field access on `getproperty(::TensorNetwork)` * Fix typos * Fix `NamedTuple` initialization with `Pairs` * Refactor `checkmeta(Quantum)` * Refactor `TensorNetwork` args and checks in constructors * Implement `fieldnames` for `TensorNetwork` object * Fix `plug` mutation * Move `hcat` test to `Quac` integration tests * Test `metadata`,`sites`,`labels`,`adjoint` on `Quantum` ansatz * Init `Composite` ansatz * Precompute `indices` mapping on `TensorNetwork`'s inner constructor * Refactor `Quantum` metadata to interlayers alas multi-layer graphs * Format code * Fix `hcat` method between `Quantum` TNs * Apply @mofeing suggestions from code review Co-authored-by: Sergio Sánchez Ramírez <15837247+mofeing@users.noreply.github.com> * Store `Plug` info in metadata * Update `Quac` extension to new `TensorNetwork` definition * Set `Bijections` compat constraint to v0.1 * Add `MPO` tests * Add `MPS` tests * Test `Quantum` code on `Operator` plug * Specialize `replace!` on Quantum TN * Fix `layers`, `hcat` * Fix `@invoke` call in Julia 1.8 * Fix `@invoke` call on ambiguous method --------- Co-authored-by: Sergio Sánchez Ramírez <sergio.sanchez.ramirez+github@bsc.es> Co-authored-by: Sergio Sánchez Ramírez <sergio.sanchez.ramirez+git@bsc.es> Co-authored-by: Jofre Vallès Muns <61060572+jofrevalles@users.noreply.github.com> Co-authored-by: Ema Puljak <ema.puljak@cern.ch>
jofrevalles
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redefines the internals of the
TensorNetworktype, removing the problematicIndextype andlinkmethods.The
TensorNetworkfields now contain:TensorsTensorsSince
Tensors contain the list of indices they are connected to, and so does the indices mapping, it is equally efficient to access aTensorNetworkgraph and its dual1 graph.This improves code complexity, composability, ...
Footnotes
Indices as nodes and tensors as (hyper)edges. ↩