Correct description of new functions #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
==========================================
- Coverage 95.30% 95.29% -0.01%
==========================================
Files 63 63
Lines 10474 10474
==========================================
- Hits 9982 9981 -1
- Misses 492 493 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fjconejero
reviewed
Mar 14, 2024
| @@ -57,6 +57,10 @@ def fit(self, x, y=None, **fit_params): | |||
|
|
|||
| def train_candidates(self, x, y, **fit_params): | |||
| """Run fit with all sets of parameters. | |||
| This method does not generate the scores. By not generating | |||
There was a problem hiding this comment.
No falta una linea en blanco entre la frase que empieza por Run... y la This method... ?
| @@ -135,6 +139,7 @@ def evaluate_candidates(candidate_params): | |||
|
|
|||
| def score(self, x=None, y=None, **fit_params): | |||
| """Compute score for the trained sets of parameters. | |||
| To compute the score a synchronization is needed. | |||
There was a problem hiding this comment.
Y otra linea vacía aquí también?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue_number)
Type of change
Please delete options that are not relevant.
Reproduce instructions:
Checklist: