Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct description of new functions #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct description of new functions #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions dislib/model_selection/_search.py
View file
Open in desktop
Expand Up @@ -57,6 +57,10 @@ def fit(self, x, y=None, **fit_params):

def train_candidates(self, x, y, **fit_params):
"""Run fit with all sets of parameters.
This method does not generate the scores. By not generating
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No falta una linea en blanco entre la frase que empieza por Run... y la This method... ?

the scores we avoid the syncrhonization of the GridSearch.
It is useful if several GridSearchs are used. To generate the
scores it will be needed to use score function.

Parameters
----------
Expand Down Expand Up @@ -135,6 +139,7 @@ def evaluate_candidates(candidate_params):

def score(self, x=None, y=None, **fit_params):
"""Compute score for the trained sets of parameters.
To compute the score a synchronization is needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y otra linea vacía aquí también?


Parameters
----------
Expand Down